Re: [PATCH RESEND v3 3/3] arm64: dts: qcom: sm7125-samsung: add initial device tree

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `rmtfs_mem` and `framebuffer` nodes violate unit address conventions, causing dtc compiler warnings.
--

commit f4aab33141cc83eeb5caf4d1bd15dc706240103e
Author: Erikas Bitovtas <xerikasxx@gmail.com>

arm64: dts: qcom: sm7125-samsung: add initial device tree

Samsung Galaxy A52/A72 are devices released on atoll (SM7125) platform
in 2021. Add initial device tree for SM7125 Samsung platform with
support for various peripherals.

> diff --git a/arch/arm64/boot/dts/qcom/sm7125-samsung-a52q.dts b/arch/arm64/boot/dts/qcom/sm7125-samsung-a52q.dts
> index 0000000000000..ecba5be8164ea
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125-samsung-a52q.dts
[ ... ]
> +&rmtfs_mem {
> +	reg = <0x0 0xf4f00000 0x0 0x202000>;
> +};

[Severity: Low]
Does this reg assignment cause a dtc compiler warning? The reg property is
assigned here without updating the node name to include the unit address
@f4f00000.

> diff --git a/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
> index 0000000000000..b8863e111bc4f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7125-samsung-common.dtsi
[ ... ]
> +		ranges;
> +
> +		framebuffer@9c000000 {
> +			compatible = "simple-framebuffer";
> +			memory-region = <&cont_splash_mem>;

[Severity: Low]
Should this node name have a unit address? The unit address @9c000000 is
present in the node name without a corresponding reg property, which usually
triggers a unit_address_vs_reg warning from the device tree compiler.

> +			width = <1080>;
[ ... ]
> +		pstore_mem: ramoops@b4600000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xb4600000 0x0 0x100000>;
> +			record-size = <0x40000>;
> +			console-size = <0x40000>;
> +			ftrace-size = <0x40000>;
> +			pmsg-size = <0x40000>;
> +		};
> +
> +		rmtfs_mem: memory {
> +			compatible = "qcom,rmtfs-mem";
> +			qcom,use-guard-pages;

[Severity: Low]
Should this node name include a unit address? This node is defined here as
memory without a unit address, but it receives a reg property in the
board-specific DTS files. This typically generates a unit_address_vs_reg dtc
warning during the build.

> +			no-map;
> +
> +			qcom,client-id = <1>;
> +			qcom,vmid = <QCOM_SCM_VMID_MSS_MSA>;
> +		};
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-sm7125-samsung-v3-0-c467bea0fb9c@gmail.com?part=3