Re: [PATCH v2 2/7] of: property: fw_devlink: Report unsupported supplier linking

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing MSI controller binding support for `msi-map` in `of_supplier_bindings`.
--

commit 47987c8dc7b7519422af5f39cc351a7527565d09
Author: Ernest Van Hoecke <ernest.vanhoecke@toradex.com>

of: property: fw_devlink: Report unsupported supplier linking

OF supplier linking is deliberately disabled on OLPC and Intel CE4100 systems.
This commit changes the add_links operation to return -EOPNOTSUPP when
supplier linking is unsupported, which allows OF unit tests to skip link
assertions on these systems.

> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 380df0861ab97..eba7e9fe6c386 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1691,7 +1691,7 @@ static int of_fwnode_add_links(struct fwnode_handle *fwnode)
>  	struct device_node *con_np = to_of_node(fwnode);
>  
>  	if (!of_is_fwnode_add_links_supported())
> -		return 0;
> +		return -EOPNOTSUPP;
>  
>  	if (!con_np)
>  		return -EINVAL;

[Severity: High]
This isn't a bug introduced by this patch, but does of_supplier_bindings
miss support for the msi-map property?

Looking at of_supplier_bindings in drivers/of/property.c:

static const struct supplier_bindings of_supplier_bindings[] = {
	...
	{ .parse_prop = parse_panel, },
	{ .parse_prop = parse_msi_parent, },
	{ .parse_prop = parse_pses, },
	...
};

Failing to handle the msi-map MSI controller DT binding variant causes
fw_devlink to not establish required dependency links. 

As a consequence, consumer devices (such as PCIe host controllers) may probe
before the MSI controller is ready, leading to MSI allocation failures and
potential device unavailability (which can render the system unusable if
critical devices like storage or network are affected).

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-fw-devlink-nexus-ready-v2-0-17ac82dbe226@toradex.com?part=2