Re: [PATCH v3] arm64: dts: altera: Move all SoCFPGA files to dts/altera

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The move changes the installation directory of Altera SoCFPGA DTBs from `intel/` to `altera/`, breaking bootloader configurations.
- [Low] Removing the `intel/` directory from the ARM/ALTERA SOCFPGA ARCHITECTURE maintainer entry leaves `arch/arm64/boot/dts/intel/Makefile` orphaned.
--

commit 323947fd2b3947f88fe8d0768788642ef6666cca
Author: Chiam, Evon <evon.chiam@altera.com>

arm64: dts: altera: Move all SoCFPGA files to dts/altera

This patch moves Altera SoCFPGA device tree files from arch/arm64/boot/dts/intel/
to arch/arm64/boot/dts/altera/ to consolidate them under a single directory. It
also updates the corresponding Makefiles and drops the intel/ path from the
SoCFPGA MAINTAINERS entry.

Link: https://lore.kernel.org/all/cd16fb78-551e-4630-83d6-a44a68e2e411@kernel.org/

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a19da74d00c9..c1e1e3fb225fa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3626,7 +3626,6 @@ F:	arch/arm/boot/dts/intel/socfpga/
>  F:	arch/arm/configs/socfpga_defconfig
>  F:	arch/arm/mach-socfpga/
>  F:	arch/arm64/boot/dts/altera/
> -F:	arch/arm64/boot/dts/intel/

[Severity: Low]
Does dropping this directory-level match leave
arch/arm64/boot/dts/intel/Makefile orphaned?

The ARM/INTEL KEEMBAY ARCHITECTURE entry explicitly matches the Keembay dts
and dtsi files, but it doesn't seem to include the directory or the Makefile
itself.

Will get_maintainer.pl still be able to identify maintainers for changes to
this Makefile?

> diff --git a/arch/arm64/boot/dts/altera/Makefile b/arch/arm64/boot/dts/altera/Makefile
> index 540bb5ae746b3..8f41349103b80 100644
> --- a/arch/arm64/boot/dts/altera/Makefile
> +++ b/arch/arm64/boot/dts/altera/Makefile
> @@ -1,5 +1,17 @@
>  # SPDX-License-Identifier: GPL-2.0-only
> -dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_stratix10_socdk.dtb \
> +dtb-$(CONFIG_ARCH_INTEL_SOCFPGA) += socfpga_agilex_n6000.dtb \

[Severity: Medium]
Will this move break bootloader configurations and deployment scripts?

Running make dtbs_install on arm64 preserves vendor directories since
CONFIG_ARCH_WANT_FLAT_DTB_INSTALL is not set.

Because the files are moved from dts/intel/ to dts/altera/ without backward
compatibility symlinks, the installed path changes (e.g., from
/boot/dtbs/x.y.z/intel/socfpga_agilex_socdk.dtb to
altera/socfpga_agilex_socdk.dtb).

Can this prevent boards from booting after a kernel upgrade if the bootloader
expects the old path?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/47719884b157863b2253b415daa447b417cd3419.1789048358.git.evon.chiam@altera.com?part=1