Re: [PATCH net-next v4 01/10] net: ethernet: ravb: Remove gPTP control from WoL setup and restore

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Meaningful code and commit message mismatch leading to unintended PTP clock lifecycle.
--

commit d9a97079fb4ac0a52b7c3683f3c046c7743362d3
Author: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

net: ethernet: ravb: Remove gPTP control from WoL setup and restore

This commit removes the explicit gPTP stop/start calls from the Wake-on-LAN
(WoL) suspend and resume paths. It asserts that opening and closing the
netdev already handles this clock control.

> As the ndev will always be closed and re-opened when
> suspending and resuming the system.

[Severity: Medium]
Is this assumption in the commit message accurate? Looking at ravb_suspend()
in drivers/net/ethernet/renesas/ravb_main.c, it appears to bypass
ravb_close() entirely when WoL is enabled:

	if (priv->wol_enabled) {
		ret = ravb_wol_setup(ndev);
		rtnl_unlock();
		return ret;
	}

	ret = ravb_close(ndev);


> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -3182,9 +3182,6 @@ static int ravb_wol_setup(struct net_device *ndev)
>  	/* Enable MagicPacket */
>  	ravb_modify(ndev, ECMR, ECMR_MPDE, ECMR_MPDE);
>  
> -	if (priv->info->ccc_gac)
> -		ravb_ptp_stop(ndev);
> -

[Severity: Medium]
Since ravb_close() is skipped for WoL suspend, does removing the explicit
ravb_ptp_stop() leave the gPTP clock running? 

It looks like this might introduce an unintended asymmetric lifecycle on
ccc_gac platforms, where the clock stays running during WoL suspend but is
then unregistered during resume when ravb_wol_restore() invokes ravb_close().

>  	return enable_irq_wake(priv->emac_irq);
>  }

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260909173027.2201560-1-niklas.soderlund+renesas@ragnatech.se?part=1