Re: [PATCH v7 02/17] dt-bindings: iio: adc: Add AD7768

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding declares GPIO provider capabilities but fails to list 'gpio-controller' and '#gpio-cells' in the 'required' list.
--

commit 4abd2d85ce51d7f09a986c8aa5389ed8989878d2
Author: Janani Sunil <janani.sunil@analog.com>

dt-bindings: iio: adc: Add AD7768

This commit adds the devicetree bindings for the AD7768-4 (4 channel) and
AD7768 (8 channel) simultaneous sampling ADCs.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
> new file mode 100644
> index 0000000000000..d8e489fa1f6ff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
[ ... ]
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
[ ... ]
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd1-supply
> +  - avdd2-supply
> +  - iovdd-supply
> +  - ref1p-supply
> +  - ref2p-supply
> +  - io-backends

[Severity: Medium]
Should gpio-controller and #gpio-cells be added to this required list?

When hardware capabilities like a GPIO controller are defined in a binding,
the corresponding standard properties must be added to the required list.
Does this regression allow incomplete device tree nodes missing the mandatory
GPIO provider properties to silently pass schema validation? 

At runtime, dependent subsystems will fail if they attempt to use the GPIO
functionality without these properties being properly constrained.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260910-ad7768-driver-v7-0-7f70b07627e1@analog.com?part=2