Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bhargav Joshi" <j.bhargav.u@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes
Date: Thu, 10 Sep 2026 22:19:01 +0000	[thread overview]
Message-ID: <20260910221902.53C001F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911-ti-dra7-omap-sham-fix-v1-1-c430f01b4e13@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] The $id field in the YAML binding schemas for ti,omap2-aes and ti,omap4-des lacks the required 'crypto/' subdirectory path component, breaking schema cross-referencing.
--

commit c96c7ea0473045fc72e713eb6392d7342cfcdd4f
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes

This patch removes the "clocks" and "clock-names" properties from the
omap-sham and omap-aes nodes in the dra7 device tree. The crypto
drivers do not use these properties, and their dt-bindings do not define
them, which currently causes dtbs_check warnings.

>     The omap-sham and omap-aes crypto drivers do not use "clocks" and
>     "clock-names" properties. Clock management is handled by the ti-sysc
>     interconnect parent wrapper. The dt-bindings for ti,omap-sham and
>     ti,omap-aes don't define these clock properties. Having them in the
>     child nodes causes dtbs_check warnings.

[Severity: Low]
This is a pre-existing issue, but the $id fields in the YAML binding schemas
for ti,omap2-aes and ti,omap4-des lack the required 'crypto/' subdirectory
path component.

For example, in Documentation/devicetree/bindings/crypto/ti,omap2-aes.yaml:

  $id: http://devicetree.org/schemas/ti,omap2-aes.yaml#

And in Documentation/devicetree/bindings/crypto/ti,omap4-des.yaml:

  $id: http://devicetree.org/schemas/ti,omap4-des.yaml#

Could this break schema cross-referencing ($ref) and cause dt_binding_check
to report misleading errors or skip validation?

Should these files be updated to include the crypto/ subdirectory path
component?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-ti-dra7-omap-sham-fix-v1-0-c430f01b4e13@gmail.com?part=1

  reply	other threads:[~2026-09-10 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 22:11 [PATCH 0/2] ARM: dts: ti: Clean up OMAP crypto bindings and dt Bhargav Joshi
2026-09-10 22:11 ` [PATCH 1/2] ARM: dts: ti: omap: dra7: Remove clocks from crypto nodes Bhargav Joshi
2026-09-10 22:19   ` sashiko-bot [this message]
2026-09-11  6:15   ` Andreas Kemnade
2026-09-10 22:11 ` [PATCH 2/2] dt-bindings: crypto: ti,omap-sham: Add OMAP3 compatible and deprecate ti,hwmods Bhargav Joshi
2026-09-11  6:24   ` Andreas Kemnade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910221902.53C001F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j.bhargav.u@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox