Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Linus Walleij" <linusw@kernel.org>
Cc: mfd@lists.linux.dev, lee@kernel.org, robh@kernel.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 7/9] ARM: dts: ux500: Add Samsung phone sound cards
Date: Thu, 10 Sep 2026 23:15:13 +0000	[thread overview]
Message-ID: <20260910231513.A99DD1F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260911-ux500-simple-sound-v1-7-6771ac714e82@kernel.org>

> The released Samsung product kernels all connect codec DAI 0 to MSP1
> for playback and codec DAI 1 to MSP3 for capture. The codec provides
> the bit and frame clocks, while ULPCLK is the machine driver's default
> audio clock parent.
> 
> Add a common Samsung simple audio card and include it from Codina,
> Codina-TMO, Gavini, Skomer, Kyle, Golden and Janice. Use the generic
> card name "Samsung". The later product kernels use DSP_A with an
> 8-by-16-bit TDM frame, playback slots 0 and 1 and capture slot 0.
> 
> Codina and HD Codina retain their older DSP_B configuration with a
> 16-by-16-bit frame and playback slots 1 and 3. Preserve Gavini's
> AMIC1A-to-VAMIC2 bias routing. Golden and Janice use the configuration
> from the newest Codina-TMO product source; their board files are
> byte-for-byte identical across the available later product releases.
> 
> Kyle's audio I2C bus contains only a disabled placeholder, so AB8505
> remains its sole active codec.
> 
> Assisted-by: LLM
> Signed-off-by: Linus Walleij <linusw@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-ux500-simple-sound-v1-0-6771ac714e82@kernel.org?part=7


  reply	other threads:[~2026-09-10 23:15 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 23:03 [PATCH 0/9] ASoC: ux500: Migrate HREF and Samsung audio to simple-card Linus Walleij
2026-09-10 23:03 ` [PATCH 1/9] ASoC: dt-bindings: ux500: Convert MSP binding to DT schema Linus Walleij
2026-09-10 23:10   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 2/9] mfd: dt-bindings: ab8500: Describe codec DAI and microphone wiring Linus Walleij
2026-09-10 23:08   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 3/9] ASoC: dt-bindings: ux500: Remove MOP500 sound card binding Linus Walleij
2026-09-10 23:07   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 4/9] ASoC: ab8500: Skip digital microphone support on AB8505 Linus Walleij
2026-09-10 23:17   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 5/9] ARM: dts: ux500: Add sound DAI provider cells Linus Walleij
2026-09-10 23:08   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 6/9] ARM: dts: ux500: Convert HREF audio card to simple-card Linus Walleij
2026-09-10 23:14   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 7/9] ARM: dts: ux500: Add Samsung phone sound cards Linus Walleij
2026-09-10 23:15   ` sashiko-bot [this message]
2026-09-10 23:03 ` [PATCH 8/9] ASoC: ux500: Remove the MOP500 machine driver Linus Walleij
2026-09-10 23:14   ` sashiko-bot
2026-09-10 23:03 ` [PATCH 9/9] ARM: config: u8500: Enable the simple audio card Linus Walleij
2026-09-10 23:09   ` sashiko-bot
2026-09-10 23:10 ` [PATCH 0/9] ASoC: ux500: Migrate HREF and Samsung audio to simple-card Mark Brown
2026-09-11  8:36   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910231513.A99DD1F00893@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox