From: sashiko-bot@kernel.org
To: "Roman Vivchar" <rva333@protonmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE
Date: Fri, 11 Sep 2026 06:41:53 +0000 [thread overview]
Message-ID: <20260911064153.C05F81F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911-mt6323-nvmem-v4-1-626dd17531dc@protonmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `efuse` object sets `unevaluatedProperties: false` but omits a `$ref` to the base NVMEM schema, preventing the use of standard NVMEM properties.
--
commit 564a77c7b7cc8f4b6a33fd5c7430ae49a1709346
Author: Roman Vivchar <rva333@protonmail.com>
dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE
The MediaTek mt6323 PMIC includes an EFUSE used for storing calibration
data. This commit adds the corresponding devicetree binding documentation.
> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> index 3cbc0dc12c319..d2de227ae7a6d 100644
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> @@ -159,6 +159,23 @@ properties:
> required:
> - compatible
>
> + efuse:
> + type: object
> + unevaluatedProperties: false
[Severity: Low]
Does this efuse object also need a $ref: /schemas/nvmem/nvmem.yaml# included?
Because unevaluatedProperties is set to false in properties.efuse without a
reference to the base nvmem schema, could this cause a schema validation
regression? It appears any device tree attempting to use standard nvmem
properties (such as read-only, wp-gpios, or #address-cells and #size-cells
for static cells) in the efuse node will incorrectly fail schema validation.
> + description:
> + The efuse is responsible for storing calibration data, such as thermal
> + sensor calibration.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-mt6323-nvmem-v4-0-626dd17531dc@protonmail.com?part=1
next prev parent reply other threads:[~2026-09-11 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 6:32 [PATCH v4 0/3] nvmem: add support for the MediaTek mt6323 PMIC Roman Vivchar via B4 Relay
2026-09-11 6:32 ` [PATCH v4 1/3] dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE Roman Vivchar via B4 Relay
2026-09-11 6:41 ` sashiko-bot [this message]
2026-09-11 6:33 ` [PATCH v4 2/3] nvmem: add mt6323 PMIC EFUSE driver Roman Vivchar via B4 Relay
2026-09-11 6:51 ` sashiko-bot
2026-09-11 6:33 ` [PATCH v4 3/3] ARM: dts: mediatek: mt6323: add EFUSE support Roman Vivchar via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260911064153.C05F81F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rva333@protonmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox