Re: [PATCH v6 05/10] ASoC: soc-core: Add snd_soc_of_xlate_dai_name() generic helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Call to non-existent function `snd_soc_dai_name_get` causes a build failure.
--

commit d2ced32400830e456cc64d54ef5e9807fdbf58e6
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: soc-core: Add snd_soc_of_xlate_dai_name() generic helper

This commit adds a generic helper to resolve a sound-dai phandle argument
to a DAI name. It iterates over a component's DAI list and matches by ID.

> diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
> index 06167a1985912..0c868bccd3b43 100644
> --- a/sound/soc/soc-core.c
> +++ b/sound/soc/soc-core.c

[ ... ]

> @@ -2906,6 +2906,39 @@ int snd_soc_of_parse_tdm_slot(struct device_node *np,
> +int snd_soc_of_xlate_dai_name(struct snd_soc_component *component,
> +			      const struct of_phandle_args *args,
> +			      const char **dai_name)
> +{
> +	struct snd_soc_dai *dai;
> +	int id;
> +
> +	if (args->args_count != 1)
> +		return -EINVAL;
> +
> +	id = args->args[0];
> +
> +	for_each_component_dais(component, dai) {
> +		if (dai->driver->id == id) {
> +			*dai_name = snd_soc_dai_name_get(dai);

[Severity: Low]
Does this cause a build failure?  It looks like snd_soc_dai_name_get() is a
typo for snd_soc_dai_name(), which will result in an undefined reference or
implicit function declaration error when compiling sound/soc/soc-core.o.

> +			return 0;
> +		}
> +	}
> +
> +	return -EINVAL;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911-b4-qaif-shikra-audio-v6-0-e9addb358201@oss.qualcomm.com?part=5