Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added compatible string `st7789v-tft28` lacks a mandatory vendor prefix, violating Devicetree specification rules.
--

commit b9c6f3f7002bdc4087c21d6e0612fcb912f52747
Author: Enzo Frese <freseenzo@gmail.com>

dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28

This commit adds a generic 2.8" 240x320 RGB LCD panel using the
Sitronix ST7789V controller to the panel-mipi-dbi-spi binding.

> diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> index 6f0290c4e2917..c28659bd05dc1 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
> @@ -75,6 +75,7 @@ properties:
>            - saef,sftc154b
>            - sainsmart18
>            - shineworld,lh133k
> +          - st7789v-tft28

[Severity: Low]
Does this compatible string violate the Devicetree specification rules
by missing a mandatory vendor prefix?

Modern dt-schema checks require compatible strings to be in the format
<vendor>,<device> to prevent global namespace pollution. Since this string
lacks a comma and an approved vendor prefix (such as sitronix,st7789v-tft28
or panel,st7789v-tft28), will this cause dt_binding_check to fail validation?

>        - const: panel-mipi-dbi-spi
>  
>    reg:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911201920.72734-1-freseenzo@gmail.com?part=1