From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH 1/2] dt-bindings: input: gpio-keys: add pinctrl states
Date: Sat, 12 Sep 2026 21:41:41 +0000 [thread overview]
Message-ID: <20260912214142.26DC61F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260912-upstream-gpio-wakeup-v1-1-f0e12484b836@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Schema constraint on `pinctrl-names` breaks validation for existing device trees using standard PM states.
--
commit 7cccd8c7baf951e7fe028bb369bca736764010d5
Author: Kendall Willis <k-willis@ti.com>
dt-bindings: input: gpio-keys: add pinctrl states
This patch adds pinctrl-0, pinctrl-1, and pinctrl-names properties to the
gpio-keys device tree binding to document the default and wakeup pin
configurations.
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
> index cc78c21529213..b554933e93412 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
[ ... ]
> + pinctrl-names:
> + description:
> + When present should contain at least "default" describing the default pin
> + states. The second state called "wakeup" describes the pins in their
> + wakeup configuration required to exit sleep states.
> + minItems: 1
> + items:
> + - const: default
> + - const: wakeup
[Severity: Medium]
Does this strict schema constraint break validation for existing device trees?
By explicitly restricting the pinctrl-names items to exactly "default" and
"wakeup" in Documentation/devicetree/bindings/input/gpio-keys.yaml, this
generic binding will now cause device tree validation (make dtbs_check) to
fail for existing upstream boards.
Many boards correctly use standard pinctrl power management states like "sleep"
(for example, pinctrl-names = "default", "sleep";) which are now rejected by
this schema.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260912-upstream-gpio-wakeup-v1-0-f0e12484b836@ti.com?part=1
next prev parent reply other threads:[~2026-09-12 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-12 21:33 [PATCH 0/2] Input: gpio-keys - support wakeup pinctrl state Kendall Willis
2026-09-12 21:33 ` [PATCH 1/2] dt-bindings: input: gpio-keys: add pinctrl states Kendall Willis
2026-09-12 21:41 ` sashiko-bot [this message]
2026-09-12 21:33 ` [PATCH 2/2] Input: gpio-keys - support wakeup pinctrl state on suspend Kendall Willis
2026-09-12 21:42 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260912214142.26DC61F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=k-willis@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox