Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Luca Weiss <luca.weiss@fairphone.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Henrik Rydberg <rydberg@bitmath.org>,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-input@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: input: touchscreen: document ESWIN EPH8621
Date: Sun, 13 Sep 2026 11:28:34 +0200	[thread overview]
Message-ID: <20260913-military-cherry-tortoise-176cab@quoll> (raw)
In-Reply-To: <20260911-eswin-eph8621-v1-1-db447ff9e445@fairphone.com>

On Fri, Sep 11, 2026 at 05:16:09PM +0200, Luca Weiss wrote:
> Document the ESWIN EPH8621 touchscreen controller, which can operate in
> SPI mode. Other touchscreen controllers from the EPH861X family (and
> potentially also EPH8621) can also operate in I2C mode, this was not
> added yet.
> 
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
>  .../bindings/input/touchscreen/eswin,eph8621.yaml  | 79 ++++++++++++++++++++++

...

> +  touchscreen-swapped-x-y: true
> +
> +additionalProperties: false

If there is going to be a new version, this should be just before
example.


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


  reply	other threads:[~2026-09-13  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 15:16 [PATCH 0/3] ESWIN EPH8621 touchscreen support for Fairphone (Gen. 6) Luca Weiss
2026-09-11 15:16 ` [PATCH 1/3] dt-bindings: input: touchscreen: document ESWIN EPH8621 Luca Weiss
2026-09-13  9:28   ` Krzysztof Kozlowski [this message]
2026-09-11 15:16 ` [PATCH 2/3] Input: Add driver for ESWIN EPH8621 touchscreen IC Luca Weiss
2026-09-11 15:26   ` sashiko-bot
2026-09-11 15:16 ` [PATCH 3/3] arm64: dts: qcom: milos-fairphone-fp6: Add touchscreen Luca Weiss
2026-09-11 15:43   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260913-military-cherry-tortoise-176cab@quoll \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rydberg@bitmath.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox