Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	 Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>,
	 Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 Paul Sajna <sajattack@postmarketos.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Thierry Reding <thierry.reding@gmail.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	dri-devel@lists.freedesktop.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH] Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible"
Date: Sun, 13 Sep 2026 11:02:14 +0200	[thread overview]
Message-ID: <20260913-succinct-spiffy-chimera-32b06b@quoll> (raw)
In-Reply-To: <20260911-topic-lg_sw49410_revert-v1-1-c9385a9e1926@oss.qualcomm.com>

On Fri, Sep 11, 2026 at 09:36:48AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> This patch had been applied before the review has concluded. The panel

"Commit foo bar had been applied..."

> needs more specific handling than the one provided by panel-simple and
> the intended compatible was supposed to contain both the display panel
> name and the driver IC model number.

You miss subject prefixes. It is "dt-bindings: dispaly: panel-simple:
Revert something".

> 
> Moreover, the other compatible that didn't make it in the end landed in
> the Qualcomm tree some time ago, instead of the one this revert
> removes, so it's not even used.
> 
> See the link for reference.
> 
> This reverts commit a74c2e55ab66519ffa2069ac9ae83cd937bff4c4.
> 
> Link: https://lore.kernel.org/all/20260614-judyln-panel-v3-2-07f4134441bd@postmarketos.org/
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Paul, please resubmit your bindings patch with the proper compatible
> and let's get it merged.

lg,sw49410 is already used, so instead new binding should be posted
moving this one from panel-simple.  Revert does not solve anything -
changes one warning into other one.

Best regards,
Krzysztof


      parent reply	other threads:[~2026-09-13  9:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  7:36 [PATCH] Revert "dt-bindings: display: panel: panel-simple: Add lg,sw49410 compatible" Konrad Dybcio
2026-09-11  7:43 ` sashiko-bot
2026-09-13  9:02 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260913-succinct-spiffy-chimera-32b06b@quoll \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=sajattack@postmarketos.org \
    --cc=sam@ravnborg.org \
    --cc=simona@ffwll.ch \
    --cc=thierry.reding@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox