From: sashiko-bot@kernel.org
To: "Alexey Minnekhanov" <alexeymin@minlexx.ru>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/9] dt-bindings: display: novatek,nt36672a: Add 5 new panels
Date: Sun, 13 Sep 2026 06:32:43 +0000 [thread overview]
Message-ID: <20260913063243.B73D61F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260913-nt36672a-panels-v1-3-ce097402c6ea@minlexx.ru>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] Incomplete Documentation Update
- [Low] Alphabetical ordering violation in compatible strings
--
commit fe459608210d248fe11d7e07e8ba300ec1c7b36a
Author: Alexey Minnekhanov <alexeymin@minlexx.ru>
dt-bindings: display: novatek,nt36672a: Add 5 new panels
This commit documents 5 new display panels that use the Novatek NT36672A
driver. These panels are used in various smartphones produced by Xiaomi
and ASUS.
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> index 5d16d85117254..3671fd788a818 100644
> --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> @@ -22,7 +22,12 @@ properties:
> compatible:
> items:
> - enum:
[Severity: Low]
Could the main description block be updated to reflect these additions?
The top-level description property for novatek,nt36672a.yaml currently says
"Right now, support is added only for a Tianma FHD+ LCD display panel with
a resolution of 1080x2246." Since this commit adds 5 new panels to the
compatible items enum below, the description is now outdated.
> + - shenchao,fhdplus-video
> - tianma,fhd-video
> + - tianma,tl060fvxs16-00
> + - tianma,tl063fvmca01-00
> + - tianma,tl063fvmc43-02
[Severity: Low]
Is it possible to sort these compatible strings alphabetically? In ASCII,
the character 4 comes before a, so it seems like "tianma,tl063fvmc43-02"
should precede "tianma,tl063fvmca01-00" in this enum list.
> + - txd,txdi600yanpa-43v3
> - const: novatek,nt36672a
> description: This indicates the panel manufacturer of the panel that is
> in turn using the NT36672A panel driver. This compatible string
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260913-nt36672a-panels-v1-0-ce097402c6ea@minlexx.ru?part=3
next prev parent reply other threads:[~2026-09-13 6:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 5:36 [PATCH 0/9] drm/panel: novatek-nt36672a: Extend with 5 new panels Alexey Minnekhanov
2026-09-13 5:36 ` [PATCH 1/9] dt-bindings: vendor-prefixes: Add Shenzhen TXD Technology Co., Ltd Alexey Minnekhanov
2026-09-13 5:36 ` [PATCH 2/9] dt-bindings: vendor-prefixes: Add Shenzhen Zhuohong Electronic Alexey Minnekhanov
2026-09-13 6:31 ` sashiko-bot
2026-09-13 5:36 ` [PATCH 3/9] dt-bindings: display: novatek,nt36672a: Add 5 new panels Alexey Minnekhanov
2026-09-13 6:32 ` sashiko-bot [this message]
2026-09-13 5:36 ` [PATCH 4/9] drm/panel: novatek-nt36672a: Set driver name to novatek for consistency Alexey Minnekhanov
2026-09-13 12:52 ` David Heidelberg
2026-09-13 5:36 ` [PATCH 5/9] drm/panel: novatek-nt36672a: Combine two init callbacks into one Alexey Minnekhanov
2026-09-13 5:36 ` [PATCH 6/9] drm/panel: novatek-nt36672a: Add 3 panels used in Xiaomi phones Alexey Minnekhanov
2026-09-13 6:34 ` sashiko-bot
2026-09-13 5:36 ` [PATCH 7/9] drm/panel: novatek-nt36672a: Add Tianma panel for Xiaomi Mi A2 Alexey Minnekhanov
2026-09-13 6:31 ` sashiko-bot
2026-09-13 5:36 ` [PATCH 8/9] drm/panel: novatek-nt36672a: Add panel for Asus Zenfone Max Pro M1 Alexey Minnekhanov
2026-09-13 12:47 ` David Heidelberg
2026-09-13 5:36 ` [PATCH 9/9] MAINTAINERS: Add Alexey Minnekhanov as maintainer for NT36672A panel Alexey Minnekhanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913063243.B73D61F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexeymin@minlexx.ru \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox