Re: [PATCH 3/4] dt-bindings: arm: airoha: Allow one thermal sensor cell for AN7583

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#thermal-sensor-cells` property uses an `enum` constraint instead of a `const` constraint.
--

commit a2ea4a9a05333c50b5a23468b0906bdb46e74f5f
Author: Vitaliy Sochnev <sochnev.v.74@gmail.com>

dt-bindings: arm: airoha: Allow one thermal sensor cell for AN7583

This commit modifies the AN7583 chip SCU device tree binding to allow
the #thermal-sensor-cells property to accept either 0 or 1. It updates
the validation constraints to use an enum instead of a strict constant.

> diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> index cc564dc7b414d..da159b7572f37 100644
> --- a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> +++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> @@ -26,7 +26,10 @@ properties:
>      maxItems: 1
>  
>    '#thermal-sensor-cells':
> -    const: 0
> +    description:
> +      0 refers to the bandgap sensor. 1 selects the sensor with one cell,
> +      0 bandgap, 1 GbE, 2 CPU.
> +    enum: [0, 1]

[Severity: Medium]
Does using an enum for this cell-count property violate the subsystem
architectural rules?

The Device Tree binding subsystem guidelines explicitly mandate that
every cell-count property must have a strict const constraint matching
the hardware.

Using an enum here allows variable cell counts for the same compatible
string, which causes schema validation to accept ambiguous hardware
configurations rather than enforcing a single hardware-matching constant
size.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260913145226.34643-1-sochnev.v.74@gmail.com?part=3