From: sashiko-bot@kernel.org
To: Quchaosheng <quchaosheng000406@163.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
linux-can@vger.kernel.org,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>,
conor+dt@kernel.org
Subject: Re: [PATCH] net: can: cc770: update the binding file reference in the driver comment
Date: Mon, 14 Sep 2026 03:06:47 +0000 [thread overview]
Message-ID: <20260914030647.7B9E31F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260914030215.437602-2-quchaosheng000406@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit updates a comment to reference a converted YAML binding file that does not exist in the repository.
--
commit e518a37460a65d07aab5618e8c0ad5c878991050
Author: Quchaosheng <quchaosheng000406@163.com>
net: can: cc770: update the binding file reference in the driver comment
This commit updates the comment at the top of the cc770 platform driver to
reference the newly converted device tree binding YAML file instead of the old
text file.
> diff --git a/drivers/net/can/cc770/cc770_platform.c b/drivers/net/can/cc770/cc770_platform.c
> index b6c4f02ffb97a..b690167c454fc 100644
> --- a/drivers/net/can/cc770/cc770_platform.c
> +++ b/drivers/net/can/cc770/cc770_platform.c
> @@ -30,8 +30,8 @@
> * bosch,external-clock-frequency = <16000000>;
> * };
> *
> - * See "Documentation/devicetree/bindings/net/can/cc770.txt" for further
> - * information.
> + * See "Documentation/devicetree/bindings/net/can/bosch,cc770.yaml" for
> + * further information.
[Severity: Low]
Does the bosch,cc770.yaml file actually exist in the repository?
It appears that Documentation/devicetree/bindings/net/can/bosch,cc770.yaml
was not added in this commit, and Documentation/devicetree/bindings/net/can/cc770.txt
is still present in the tree.
Is this patch part of a larger series where the YAML conversion happens in a
different commit that wasn't included?
> */
>
> #include <linux/kernel.h>
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260914030215.437602-2-quchaosheng000406@163.com?part=1
next prev parent reply other threads:[~2026-09-14 3:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 3:02 [PATCH] dt-bindings: net: can: bosch,cc770: Convert to DT schema Quchaosheng
2026-09-14 3:02 ` [PATCH] net: can: cc770: update the binding file reference in the driver comment Quchaosheng
2026-09-14 3:06 ` sashiko-bot [this message]
2026-09-14 3:02 ` [PATCH] dt-bindings: net: can: holt,hi3110: Convert to DT schema Quchaosheng
2026-09-14 3:12 ` sashiko-bot
2026-09-15 10:52 ` Krzysztof Kozlowski
2026-09-14 3:02 ` [PATCH] dt-bindings: net: can: fsl,mpc5xxx-mscan: " Quchaosheng
2026-09-14 3:12 ` sashiko-bot
2026-09-14 3:09 ` [PATCH] dt-bindings: net: can: bosch,cc770: " sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914030647.7B9E31F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
--cc=o.rempel@pengutronix.de \
--cc=quchaosheng000406@163.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).