Re: [PATCH v3 2/2] dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `$ref` type definition for vendor property `fsl,mscan-clock-source`.
--

commit 0f4e0331aedb88733ad8480e58d0cb6aed274e62
Author: Quchaosheng <quchaosheng000406@163.com>

dt-bindings: net: can: fsl,mpc5xxx-mscan: Convert to DT schema

This commit converts the Freescale MPC5xxx MSCAN binding from free-form
text to DT schema format. It describes multiple controller variants, sets
up clock definitions, and introduces conditional properties for different
compatible strings.

> diff --git a/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml
> new file mode 100644
> index 0000000000000..277e78ca21f11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/fsl,mpc5xxx-mscan.yaml

[ ... ]

> +  clock-names:
> +    items:
> +      - const: ipg
> +      - const: ips
> +      - const: sys
> +      - const: ref
> +      - const: mclk
> +
> +  fsl,mscan-clock-source:
> +    description:
> +      Clock source used for the controller.
> +    enum: [ip, ref, sys]

[Severity: Low]
Does this custom property need an explicit type definition?

Vendor-specific custom properties without a standard type suffix typically
require an explicit type reference to pass dt-schema validation when running
make dt_binding_check.

Even though the allowed values are defined via an enum, a base type reference
such as `$ref: /schemas/types.yaml#/definitions/string` is usually required
to prevent build-time tooling failures.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914090440.552884-1-quchaosheng000406@163.com?part=2