Re: [PATCH v3 1/2] dt-bindings: hwmon: pmbus: Add Infineon tda38740 and tda38725

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3264 bytes --]

On Mon, Sep 14, 2026 at 05:12:59PM +0800, Colin Huang wrote:
> Conor Dooley <conor@kernel.org> 於 2026年9月10日週四 下午7:24寫道：
> >
> > On Thu, Sep 10, 2026 at 02:18:55PM +0800, Colin Huang wrote:
> > > From: Colin Huang <u8813345@gmail.com>
> > >
> > > Add devicetree bindings for the Infineon TDA38740 and TDA38725
> > > single-voltage synchronous buck regulators with PMBus interface.
> > >
> > > Signed-off-by: Colin Huang <u8813345@gmail.com>
> > > ---
> > >  .../bindings/hwmon/pmbus/infineon,tda38740.yaml    | 87 ++++++++++++++++++++++
> > >  1 file changed, 87 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> > > new file mode 100644
> > > index 000000000000..28e6ff9d9d9c
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/infineon,tda38740.yaml
> > > @@ -0,0 +1,87 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +
> > > +$id: http://devicetree.org/schemas/hwmon/pmbus/infineon,tda38740.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Infineon TDA38740 and TDA38725 PMBus Synchronous Buck Regulator
> > > +
> > > +maintainers:
> > > +  - Colin Huang <u8813345@gmail.com>
> > > +
> > > +description: |
> > > +  The Infineon TDA38740/TDA38725 is a 40A/25A single-voltage synchronous
> > > +  buck regulator with a PMBus interface designed for industrial use.
> > > +
> > > +  Datasheet:
> > > +  https://www.infineon.com/row/public/documents/24/49/infineon-tda38740-tda38725-datasheet-en.pdf
> > > +
> > > +properties:
> > > +  compatible:
> > > +    oneOf:
> > > +      - const: infineon,tda38740
> > > +      - const: infineon,tda38725
> > > +    description: |
> > > +      The Infineon TDA38740 and TDA38725 share the same PMBus programming
> > > +      model. Use infineon,tda38740 as the preferred compatible string;
> > > +      infineon,tda38725 is kept as a compatibility alias.
> >
> > This is not how this should be done. Instead, tda38725 should list
> > tda38740 as a fallback compatible. Take a look at the example schema for
> > how this can be done.
> > Otherwise, this looks okay to me.
> >
> > pw-bot: changes-requested
> >
> > Thanks,
> > Conor.
> >
> Hi Conor,
> Thanks for review and explanation.
> I misunderstood the intended use of fallback compatible.
> My v4 proposal was not correct approach.
> ```v4 used:
>  compatible:
>    enum:
>      - infineon,tda38725
>      - infineon,tda38740
> ```
> 
> I plan to change it and examples to:
> ```
>   compatible:
>     oneOf:
>       - const: infineon,tda38740
>       - items:
>           - const: infineon,tda38725
>           - const: infineon,tda38740
> 
> examples:
>   - |
>     i2c {
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         regulator@40 {
>             compatible = "infineon,tda38725",
>                          "infineon,tda38740";
>             reg = <0x40>;
>         };
>     };
> 
> ```
> Is this what you had in mind?

Yea that is what I was looking for.

Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]