Re: [PATCH 3/9] dt-bindings: riscv: Add MIPS Boston board compatible

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2389 bytes --]

On Mon, Sep 14, 2026 at 03:55:51PM +0200, Aleksa Paunovic via B4 Relay wrote:
> From: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> 
> Document the MIPS Boston board compatible with a P8700 bitfile.
> 
> Co-developed-by: Djordje Todorovic <djordje.todorovic@htecgroup.com>
> Signed-off-by: Djordje Todorovic <djordje.todorovic@htecgroup.com>
> Signed-off-by: Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> ---
>  Documentation/devicetree/bindings/riscv/gf.yaml | 27 +++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/riscv/gf.yaml b/Documentation/devicetree/bindings/riscv/gf.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..060910c9b04f482aee6f08f8f72232acbad118bb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/gf.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/gf.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GlobalFoundries MIPS SoC-based boards
> +
> +maintainers:
> +  - Djordje Todorovic <djordje.todorovic@htecgroup.com>
> +  - Aleksa Paunovic <aleksa.paunovic@htecgroup.com>
> +
> +description:
> +  GlobalFoundries MIPS SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - description: Boston FPGA development board with a MIPS P8700 bitfile

I'm not convinced that this is specific enough at all.
I have absolutely no idea from this description if there's even a
specific FPGA involved here - this could mean a bitstream used on an Altera
platform or a Xilinx one, with totally different contents.
I'm only happy with FPGA bitstream content being supported if it is
versioned strictly and matches with some clear and obvious releases from
the vendor. I cannot even find this board by googling it, let alone find
clear information about what this could correspond to.

> +        items:
> +          - const: gf,mips-p8700-boston

"items: - const" is the same as just having "const". SoC-specific
fallback is also missing, although in this case it'll be tricky to have
a meaningful one.

pw-bot: changes-requested

Thanks,
Conor.

> +
> +additionalProperties: true
> +
> +...
> 
> -- 
> 2.43.0
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]