Re: [PATCH v4 1/3] dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: mutually exclusive board and SoC compatible strings
--

commit c55f57a1517ca9ce82e67923ff8313d8fc20239f
Author: Stanislav Zaikin <zstaseg@gmail.com>

dt-bindings: soc: qcom: add xiaomi,taoyao-pmic-glink compatible

This commit adds the xiaomi,taoyao-pmic-glink compatible string for the
Xiaomi 12 Lite 5G to the pmic-glink binding.

> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 16ad4f5698fc3..8ca057c4e3e61 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -41,6 +41,7 @@ properties:
>        - items:
>            - enum:
>                - qcom,sm7325-pmic-glink
> +              - xiaomi,taoyao-pmic-glink
>            - const: qcom,qcm6490-pmic-glink
>            - const: qcom,pmic-glink

[Severity: Low]
Does this force the compatible strings to be mutually exclusive and limit the
fallback chain to exactly 3 items?

Standard Device Tree design dictates that compatible strings should be ordered
from most-specific (board) to least-specific (SoC, generic). A board-specific
compatible string for a subsystem should fall back to the SoC-specific string if
they share the same underlying hardware.

By adding xiaomi,taoyao-pmic-glink to the same enum as qcom,sm7325-pmic-glink
in a 3-item list, the schema forces the DT author to choose one or the other,
preventing a complete fallback chain.

As a result, the DT is forced to drop the qcom,sm7325-pmic-glink fallback
string to pass schema validation. This breaks the standard DT fallback chain.

Should the schema instead define a separate 4-item list under oneOf to enforce
the board string, followed by the SoC string, followed by the base fallbacks?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915084901.56622-1-zstaseg@gmail.com?part=1