Re: [PATCH 2/2] gpio: Support ON Semi CAT9532

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] i2c: i2c_device_id array missing named initializers
--

commit ce4c104d77312ee9164e59bc58ade163f20cd3c0
Author: Alban Bedel <alban.bedel@lht.dlh.de>

gpio: Support ON Semi CAT9532
    
This commit adds support for the CAT9532 LED dimmer from On Semiconductor,
implementing it as an open-drain GPIO controller driver.

> diff --git a/drivers/gpio/gpio-cat9532.c b/drivers/gpio/gpio-cat9532.c
> new file mode 100644
> index 0000000000000..973ff74a15b89
> --- /dev/null
> +++ b/drivers/gpio/gpio-cat9532.c

[ ... ]

> +static const struct i2c_device_id cat9532_i2c_id[] = {
> +	{ "cat9532" },

[Severity: Low]
This isn't a bug, but does this array initialization in cat9532_i2c_id
violate the I2C subsystem rule requiring named initializers for
struct i2c_device_id? 

Using positional initialization like { "cat9532" } instead of
{ .name = "cat9532" } goes against the documented subsystem style guidelines.

> +	{ },
> +};
> +MODULE_DEVICE_TABLE(i2c, cat9532_i2c_id);

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915092046.931449-1-alban.bedel@lht.dlh.de?part=2