Re: [PATCH v2 1/3] dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing INT2 power domain in Kaanapali MDSS example
--

commit fc3449e10374106de27dd1a562563cdee9c4085f
Author: Yongxing Mou <yongxing.mou@oss.qualcomm.com>

dt-bindings: display: msm: Add INT2 GDSC to Kaanapali DPU

Kaanapali (SM8850) has an additional INT2 GDSC that powers a subset
of the DPU source pipes (VIG2/VIG3/DMA5), on top of the CORE_GDSC
that powers the rest of the MDSS hardware. This commit describes INT2 GDSC
as an additional power domain of the DPU device rather than of the whole
MDSS and restricts the schema change to the Kaanapali DPU compatible.

> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
> index aa0cf0ec5b93f..88aa71d2b9120 100644
> --- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
[ ... ]
> @@ -61,6 +61,29 @@ required:
>    - clocks
>    - clock-names
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,kaanapali-dpu
> +    then:
> +      properties:
> +        power-domains:
> +          items:
> +            - description: MMCX power domain
> +            - description: INT2 GDSC power domain
> +
> +        power-domain-names:
> +          minItems: 2
> +          maxItems: 2
> +          items:
> +            - const: mmcx
> +            - const: int2
> +
> +      required:
> +        - power-domain-names

[Severity: Low]
Does this new requirement break the example in the qcom,kaanapali-mdss
binding?

The example in 
Documentation/devicetree/bindings/display/msm/qcom,kaanapali-mdss.yaml
defines a display-controller node with compatible = "qcom,kaanapali-dpu"
but only provides one power domain:

        display-controller@9801000 {
            compatible = "qcom,kaanapali-dpu";
            ...
            power-domains = <&rpmhpd RPMHPD_MMCX>;

Since the new constraints require two power domains and power-domain-names
for this compatible string, should the example be updated to avoid failing
the make dt_binding_check validation?

>  unevaluatedProperties: false
>  
>  examples:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-msm_gdsc2-v2-0-9157237b8382@oss.qualcomm.com?part=1