Re: [PATCH v2 net-next] dt-bindings: net: Use consistent indentation in the example

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Removing the mdio node in the cortina,gemini-ethernet.yaml example leaves dangling phandle references to &phy0 and &phy1, which causes a build failure during dt_binding_check.
--

commit 31fca947f12eff24c11e065baded031398b74f19
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: net: Use consistent indentation in the example

Correct indentation in the examples to consistent 2- or 4-spaces
indentation to fix dt-check-style warnings ("example 0
[indent-consistent] indent mismatch ...").  Preferred is 4-spaces, but
re-indenting entire example just for that is too much churn.

In cortina,gemini-ethernet.yaml also drop the wrongly indented mdio bus,
because it is not necessary for the example.

> diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> index f0b5bea2458d5..da9bc170cd543 100644
> --- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> @@ -87,18 +87,6 @@ examples:
>      #include <dt-bindings/interrupt-controller/irq.h>
>      #include <dt-bindings/clock/cortina,gemini-clock.h>
>      #include <dt-bindings/reset/cortina,gemini-reset.h>
> -    mdio0: mdio {
> -      #address-cells = <1>;
> -      #size-cells = <0>;
> -      phy0: ethernet-phy@1 {
> -        reg = <1>;
> -        device_type = "ethernet-phy";
> -      };
> -      phy1: ethernet-phy@3 {
> -        reg = <3>;
> -        device_type = "ethernet-phy";
> -      };
> -    };
>  
>      ethernet@60000000 {
>          compatible = "cortina,gemini-ethernet";
> @@ -110,28 +98,28 @@ examples:
>          ranges;
>  
>          gmac0: ethernet-port@0 {
> -                compatible = "cortina,gemini-ethernet-port";
> -                reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
> -                      <0x6000a000 0x2000>; /* Port 0 GMAC */
> -                interrupt-parent = <&intcon>;
> -                interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> -                resets = <&syscon GEMINI_RESET_GMAC0>;
> -                clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
> -                clock-names = "PCLK";
> -                phy-mode = "rgmii";
> -                phy-handle = <&phy0>;
> +            compatible = "cortina,gemini-ethernet-port";
> +            reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
> +                  <0x6000a000 0x2000>; /* Port 0 GMAC */
> +            interrupt-parent = <&intcon>;
> +            interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> +            resets = <&syscon GEMINI_RESET_GMAC0>;
> +            clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
> +            clock-names = "PCLK";
> +            phy-mode = "rgmii";
> +            phy-handle = <&phy0>;

[Severity: Low]
Does removing the mdio node leave a dangling phandle reference to &phy0 here?
This causes a build failure during dt_binding_check when the Device Tree
Compiler evaluates the undefined label.

>          };
>  
>          gmac1: ethernet-port@1 {
> -                compatible = "cortina,gemini-ethernet-port";
> -                reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
> -                      <0x6000e000 0x2000>; /* Port 1 GMAC */
> -                interrupt-parent = <&intcon>;
> -                interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> -                resets = <&syscon GEMINI_RESET_GMAC1>;
> -                clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
> -                clock-names = "PCLK";
> -                phy-mode = "rgmii";
> -                phy-handle = <&phy1>;
> +            compatible = "cortina,gemini-ethernet-port";
> +            reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
> +                  <0x6000e000 0x2000>; /* Port 1 GMAC */
> +            interrupt-parent = <&intcon>;
> +            interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> +            resets = <&syscon GEMINI_RESET_GMAC1>;
> +            clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
> +            clock-names = "PCLK";
> +            phy-mode = "rgmii";
> +            phy-handle = <&phy1>;

[Severity: Low]
And does this similarly leave a dangling reference to the newly removed &phy1
label, causing a compilation failure?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260914155645.112508-2-krzysztof.kozlowski@oss.qualcomm.com?part=1