From: sashiko-bot@kernel.org
To: "Pradhan, Sanman" <sanman.pradhan@hpe.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v2 1/3] hwmon: (pmbus/tps53679) Fix TPS53676 phase page decoding
Date: Tue, 15 Sep 2026 16:53:34 +0000 [thread overview]
Message-ID: <20260915165334.7F4DC1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915164823.160977-2-sanman.pradhan@hpe.com>
> From: Sanman Pradhan <psanman@juniper.net>
>
> tps53676_identify() reads the USER_DATA_03 phase configuration to count
> the phases assigned to each channel and derive the number of PMBus pages.
> In each 16-bit phase descriptor the channel (PAGE) is encoded in bit 4 and
> the firing order in bits 3:0, but the code tested bit 3 (0x08), which is
> part of the firing-order field.
>
> TPS53676 supports up to seven phases, so firing-order bit 3 is never set.
> As a result the existing test classifies every enabled phase as channel A.
> On a dual-channel configuration the phases assigned to channel B are
> therefore miscounted as channel A and page 1 is not exposed.
>
> Test the PAGE field (bit 4) instead.
>
> Fixes: cb3d37b59012 ("hwmon: (pmbus/tps53679) Add support for TI TPS53676")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sanman Pradhan <psanman@juniper.net>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915164823.160977-1-sanman.pradhan@hpe.com?part=1
next prev parent reply other threads:[~2026-09-15 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 16:48 [PATCH v2 0/3] hwmon: (pmbus/tps53679) Add TPS536C7 Pradhan, Sanman
2026-09-15 16:48 ` [PATCH v2 1/3] hwmon: (pmbus/tps53679) Fix TPS53676 phase page decoding Pradhan, Sanman
2026-09-15 16:53 ` sashiko-bot [this message]
2026-09-15 17:31 ` Guenter Roeck
2026-09-16 14:56 ` Guenter Roeck
2026-09-16 17:46 ` Pradhan, Sanman
2026-09-16 17:59 ` Guenter Roeck
2026-09-16 18:44 ` Pradhan, Sanman
2026-09-15 16:48 ` [PATCH v2 2/3] dt-bindings: trivial-devices: Add TI TPS536C7 Pradhan, Sanman
2026-09-15 16:52 ` sashiko-bot
2026-09-16 14:57 ` Guenter Roeck
2026-09-15 16:48 ` [PATCH v2 3/3] hwmon: (pmbus/tps53679) Add support for TPS536C7 Pradhan, Sanman
2026-09-15 16:57 ` sashiko-bot
2026-09-16 14:59 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915165334.7F4DC1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sanman.pradhan@hpe.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox