Re: [PATCH v4 7/7] dtc: dt-check-style: Relax property ordering rules (drop alphabetical)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] scripts/dtc: missing pairing rule for #size-cells in dt-check-style
--

commit 15a33e22443049ad6dfd20bb7612f0fac6037dcf
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Relax property ordering rules (drop alphabetical)

Existing rules checked whether properties follow DTS Coding Style
guidelines in respect of common properties and standard vs vendor
properties, plus additionally it enforced alphabetical order within each
of such group. This commit relaxes the property order rules to skip
alphabetical sorting and only check logical groupings.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index cbbb8d384aca2..b8c40873905c3 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
[ ... ]
> @@ -803,33 +777,27 @@ def _pair_x_names(name, all_names):
>  PAIRING_RULES = (_pair_pinctrl_names, _pair_x_names)

[Severity: Low]
Is this missing a pairing rule for #size-cells?

The docstring for check_property_order() explicitly notes that #size-cells
must follow #address-cells, but it looks like the implementation for this
rule was omitted from PAIRING_RULES.

>  
> -def _property_sort_key(dl, name, all_names):
[ ... ]
>  def check_property_order(ctx):
> -    """Properties within a node body must appear in canonical order:
> -    compatible, reg(/reg-names), ranges, then the standard group, then
> -    the vendor-specific group, then status. Inside the standard and
> -    vendor groups, pairing rules apply (e.g. <x>-names follows <x>);
> -    everything else falls back to natural sort by the #-stripped name."""
> +    """Properties within a node body must be grouped in canonical
> +    order: device_type ('model' for the root node), compatible,
> +    reg(/reg-names), ranges, then the standard group, then the
> +    vendor-specific group, then status.
> +
> +    The order of properties within one group is free, e.g. it does not
> +    matter whether '#address-cells' comes before or after 'clocks'.
> +    Paired properties still keep their relative order: <x>-names
> +    follows <x> (clocks/clock-names, reg/reg-names, ...), pinctrl-names
> +    follows the pinctrl-N states and #size-cells follows
> +    #address-cells."""
>      lines = ctx.lines

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-b4-dts-style-checker-continued-lines-v4-0-5b8e09b11ef2@oss.qualcomm.com?part=7