Re: [PATCH v2 13/15] dt-bindings: iio: adc: adi,ad4134: Add high data throughput example

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: iio: adi,ad4134: conflicting ODR pin configuration in example
--

commit be1a4d1c0eae8c4f9247540fa11bc671216046b8
Author: Marcelo Schmitt <marcelo.schmitt@analog.com>

dt-bindings: iio: adc: adi,ad4134: Add high data throughput example
    
Add device tree example for AD4134 operation in 4-wire SPI mode with 4
lines to transfer data samples to the host controller.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> index ad67d1cdacec8..133996917ee22 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4134.yaml

[ ... ]

> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "adi,ad4134";
> +            reg = <0>;
> +
> +            spi-max-frequency = <1000000>;
> +            spi-rx-bus-width = <1>, <1>, <1>, <1>; /* 4 lanes of 1 bit each */
> +
> +            pwms = <&ad4134_odr_generator 1 1000000 0>;
> +            reset-gpios = <&gpio0 86 GPIO_ACTIVE_LOW>;
> +            odr-gpios = <&gpio0 87 GPIO_ACTIVE_HIGH>;

[Severity: Low]
Does this example create a logical hardware conflict?

Both a PWM (pwms) and a GPIO (odr-gpios) are assigned to the exact same
physical ODR pin. Additionally, odr-gpios is explicitly documented to be used
for minimum I/O mode, but this example configures adi,spi-mode = "4-wire". 

Could this cause developers copying this example to create device trees with
conflicting and semantically incorrect properties for the chosen SPI mode?

> +            powerdown-gpios = <&gpio0 88 GPIO_ACTIVE_LOW>;
> +
> +            clocks = <&sys_clk>;
> +            clock-names = "clkin";
> +
> +            avdd5-supply = <&avdd5>;
> +            dvdd5-supply = <&dvdd5>;
> +            iovdd-supply = <&iovdd>;
> +            refin-supply = <&refin>;
> +            avdd1v8-supply = <&avdd1v8>;
> +            dvdd1v8-supply = <&dvdd1v8>;
> +            clkvdd-supply = <&clkvdd>;
> +
> +            mux-states = <&ad4134_sdo_dout0_mux 0>, <&ad4134_sdo_dout0_mux 1>;
> +            mux-state-names = "data_read", "reg_access";
> +
> +            adi,spi-mode = "4-wire";
> +        };
> +    };
>  ...

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1789494473.git.marcelo.schmitt@analog.com?part=13