Re: [PATCH v2 2/3] arm64: dts: qcom: glymur: Add Asus Zenbook A14 (UX3407NA)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: copy-paste error leaves second USB MP PHY and redriver enabled
--

commit 0d6d4b3a24e525ee48e9f58d17b7e42d0de45fa5
Author: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>

arm64: dts: qcom: glymur: Add Asus Zenbook A14 (UX3407NA)

This commit adds device tree support for the Asus Zenbook A14 (UX3407NA)
variant built on the Qualcomm Glymur platform. It introduces the base
hardware description, including the X2 Elite SoC, storage, display,
and USB connectivity.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a14-ux3407na.dts b/arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a14-ux3407na.dts
> new file mode 100644
> index 0000000000000..e96e65a0c5b49
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a14-ux3407na.dts
[ ... ]
> +&i2c5 {
> +	clock-frequency = <400000>;
> +
> +	status = "okay";
> +
> +	ptn3222_1: redriver@43 {
> +		compatible = "nxp,ptn3222";
> +		reg = <0x43>;
> +
> +		reset-gpios = <&tlmm 184 GPIO_ACTIVE_LOW>;
> +
> +		vdd3v3-supply = <&vreg_l8b0>;
> +		vdd1v8-supply = <&vreg_l15b0>;
> +
> +		#phy-cells = <0>;
> +	};

[Severity: Medium]
The commit message explicitly states the device has "one USB Type-A" and
makes no mention of an SD card reader. Does this hardware actually have a
second redriver, or is ptn3222_1 a leftover from another model's configuration?

If this hardware does not exist on the board, the kernel will attempt to probe
a non-existent I2C redriver which can cause boot probe errors.

[ ... ]
> +&usb_mp_hsphy1 {
> +	vdd-supply = <&vreg_l2h0>;
> +	vdda12-supply = <&vreg_l4h0>;
> +
> +	phys = <&ptn3222_1>;
> +
> +	status = "okay";
> +};

[Severity: Medium]
The second Multi-Port PHY is fully enabled here, which directly contradicts
the commit message's claim of a single Type-A port. 

Could enabling this second PHY waste power and cause initialization errors by
attempting to bring up non-existent hardware on the boot path?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-zenbook-dts-v2-0-41de8669a7a8@oss.qualcomm.com?part=2