From: Moteen Shah <m-shah@ti.com>
To: <ilpo.jarvinen@linux.intel.com>, <gregkh@linuxfoundation.org>,
<krzk+dt@kernel.org>, <linux-serial@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <jirislaby@kernel.org>,
<devicetree@vger.kernel.org>
Cc: <u-kumar1@ti.com>, <gehariprasath@ti.com>, <m-shah@ti.com>,
<vigneshr@ti.com>, <nm@ti.com>, <a-limaye@ti.com>,
<y-abhilashchandra@ti.com>
Subject: [PATCH v2 0/2] serial: 8250_dw: Add ti,tda54-uart support
Date: Wed, 16 Sep 2026 14:25:18 +0530 [thread overview]
Message-ID: <20260916085520.2259420-1-m-shah@ti.com> (raw)
Add the ti,tda54-uart compatible string to the DW APB UART binding,
and add a capabililty to skip empty FIFO read on TDA54.
Reading an empty FIFO on the IP version used in TDA54 triggers a
data abort. The interrupt storm this dummy read was meant to avoid
no longer occurs on this version of the IP, so skip the read via a
new capability. Also, guard the empty FIFO reads during startup and
shutdown of the port using the same capability.
Changes since v1:
Link: https://lore.kernel.org/all/20260911092529.306082-1-m-shah@ti.com/
- Gate the empty FIFO read during startup and shutdown of the UART
port using the new capability.
- Make use of the new capability in the driver as to skip empty
FIFO read, replacing the quirk which was being used.
Moteen Shah (2):
dt-bindings: serial: snps-dw-apb-uart: Add ti,tda54-uart
serial: 8250_dw: Add capability to skip empty FIFO read
.../bindings/serial/snps-dw-apb-uart.yaml | 1 +
drivers/tty/serial/8250/8250.h | 1 +
drivers/tty/serial/8250/8250_dw.c | 16 +++++++++++++++-
drivers/tty/serial/8250/8250_port.c | 12 +++++++++---
4 files changed, 26 insertions(+), 4 deletions(-)
--
2.34.1
next reply other threads:[~2026-09-16 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 8:55 Moteen Shah [this message]
2026-09-16 8:55 ` [PATCH v2 1/2] dt-bindings: serial: snps-dw-apb-uart: Add ti,tda54-uart Moteen Shah
2026-09-16 8:59 ` sashiko-bot
2026-09-16 8:55 ` [PATCH v2 2/2] serial: 8250_dw: Add capability to skip empty FIFO read Moteen Shah
2026-09-16 9:05 ` sashiko-bot
2026-09-16 10:52 ` Ilpo Järvinen
2026-09-16 12:55 ` Moteen Shah
2026-09-16 14:32 ` Hari Prasath G E
2026-09-16 13:47 ` Kumar, Udit
2026-09-17 9:40 ` Ilpo Järvinen
2026-09-18 4:05 ` Kumar, Udit
2026-09-18 9:23 ` Moteen Shah
2026-09-18 9:56 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916085520.2259420-1-m-shah@ti.com \
--to=m-shah@ti.com \
--cc=a-limaye@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gehariprasath@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nm@ti.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox