From: sashiko-bot@kernel.org
To: "Janani Sunil" <janani.sunil@analog.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v8 02/17] dt-bindings: iio: adc: Add AD7768
Date: Wed, 16 Sep 2026 11:23:05 +0000 [thread overview]
Message-ID: <20260916112305.AB4241F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260916-ad7768-driver-v8-2-27aa24db5225@analog.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: iio: adc: ad7768 missing gpio provider properties in required list
--
commit 8814b3f3517006545039f4ea86c2f40654d4c3d3
Author: Janani Sunil <janani.sunil@analog.com>
dt-bindings: iio: adc: Add AD7768
This commit introduces the devicetree bindings for the AD7768 and AD7768-4
simultaneous sampling ADCs operating in SPI mode.
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
> new file mode 100644
> index 0000000000000..d8e489fa1f6ff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
[ ... ]
> + gpio-controller: true
> +
> + '#gpio-cells':
> + const: 2
[ ... ]
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - avdd1-supply
> + - avdd2-supply
> + - iovdd-supply
> + - ref1p-supply
> + - ref2p-supply
> + - io-backends
[Severity: Low]
Should gpio-controller and #gpio-cells be appended to this required list?
When hardware provides capabilities such as a GPIO controller, subsystem
guidelines specify that the corresponding standard properties must be explicitly
enforced. Without these in the global required list, incomplete device tree
nodes that claim GPIO controller capabilities but omit the required cell
properties (or omit the provider properties entirely) will silently pass
static schema validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-ad7768-driver-v8-0-27aa24db5225@analog.com?part=2
next prev parent reply other threads:[~2026-09-16 11:23 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 11:13 [PATCH v8 00/17] iio: adc: Add AD7768/AD7768-4 ADC driver support Janani Sunil
2026-09-16 11:13 ` [PATCH v8 01/17] iio: adc: adi-axi-adc: Initialize state mutex Janani Sunil
2026-09-16 11:13 ` [PATCH v8 02/17] dt-bindings: iio: adc: Add AD7768 Janani Sunil
2026-09-16 11:23 ` sashiko-bot [this message]
2026-09-16 11:13 ` [PATCH v8 03/17] iio: backend: Add support for CRC Janani Sunil
2026-09-16 11:13 ` [PATCH v8 04/17] iio: adc: adi-axi-adc: " Janani Sunil
2026-09-16 11:25 ` sashiko-bot
2026-09-16 11:13 ` [PATCH v8 05/17] iio: adc: Add AD7768 and AD7768-4 core support Janani Sunil
2026-09-16 11:29 ` sashiko-bot
2026-09-21 0:31 ` Jonathan Cameron
2026-09-16 11:13 ` [PATCH v8 06/17] iio: adc: ad7768: Validate master clock rate Janani Sunil
2026-09-16 11:13 ` [PATCH v8 07/17] iio: adc: ad7768: Add power mode helper Janani Sunil
2026-09-16 11:13 ` [PATCH v8 08/17] iio: adc: ad7768: Derive output data rates Janani Sunil
2026-09-16 11:13 ` [PATCH v8 09/17] iio: adc: ad7768: Configure channel sampling profiles Janani Sunil
2026-09-16 11:13 ` [PATCH v8 10/17] iio: adc: ad7768: Add sampling frequency controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 11/17] iio: adc: ad7768: Add per-channel filter controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 12/17] iio: adc: ad7768: Wait for digital filters to settle Janani Sunil
2026-09-16 11:14 ` [PATCH v8 13/17] iio: adc: ad7768: Add calibration controls Janani Sunil
2026-09-16 11:14 ` [PATCH v8 14/17] iio: adc: ad7768: Add per-channel conversion delay Janani Sunil
2026-09-16 11:14 ` [PATCH v8 15/17] iio: adc: ad7768: Add VCM regulator support Janani Sunil
2026-09-16 11:14 ` [PATCH v8 16/17] iio: adc: ad7768: Register GPIO auxiliary device Janani Sunil
2026-09-16 11:14 ` [PATCH v8 17/17] Documentation: iio: Add AD7768 Documentation Janani Sunil
2026-09-21 0:37 ` [PATCH v8 00/17] iio: adc: Add AD7768/AD7768-4 ADC driver support Jonathan Cameron
2026-09-21 8:46 ` Janani Sunil
2026-09-22 0:13 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916112305.AB4241F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=janani.sunil@analog.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox