Re: [PATCH v2 12/19] dt-bindings: clock: qcom,rpmcc: Add MSM8952 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing qcom,rpmcc-msm8952 in allOf conditional block
--

commit 1a36458fc826545d7c948ae6e71fb8e460a8f8cc
Author: Muzaffer Kadir <muzafferkadir@mainlining.org>

dt-bindings: clock: qcom,rpmcc: Add MSM8952 compatible
    
Document the rpmcc found on MSM8952.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> index 17332aa558862..aa532f208f5af 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml
> @@ -56,6 +56,11 @@ properties:
>                - qcom,rpmcc-shikra
>            - const: qcom,rpmcc-qcm2290
>            - const: qcom,rpmcc
> +      - items:
> +          - enum:
> +              - qcom,rpmcc-msm8952
> +          - const: qcom,rpmcc-msm8976
> +          - const: qcom,rpmcc

[Severity: Low]
Should qcom,rpmcc-msm8952 also be added to the allOf conditional block further
down in the file?

The new compatible string is defined here, but appears to be missing from the
explicit enumeration block under allOf:if:properties:compatible:

Documentation/devicetree/bindings/clock/qcom,rpmcc.yaml:
          contains:
            enum:
              ...
              - qcom,rpmcc-msm8953
              - qcom,rpmcc-msm8974
              - qcom,rpmcc-msm8976
              - qcom,rpmcc-msm8992

Without it in this block, device tree schema validation for the new compatible
string will be incomplete if a node uses it without the fallback string,
potentially allowing invalid clock configurations (such as the wrong number or
names of clocks) to silently pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-msm8952-initial-support-v2-0-798c2602dde1@mainlining.org?part=12