Re: [PATCH v2 1/3] dt-bindings: phy: qcom,snps-eusb2-phy: Document the Nord eUSB2 PHY

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: snps-eusb2-phy weakens validation by dropping required resets
--

commit 40f3e2fd7afd242254a8fb682a03903a7a5acc6d
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

dt-bindings: phy: qcom,snps-eusb2-phy: Document the Nord eUSB2 PHY

Add a compatible for the eUSB2 PHY found on the Qualcomm Nord SoC. This 
commit removes the resets property from the globally required list, as the 
Nord SoC does not have a dedicated PHY reset for the HS-only USB20 tile.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> index 096f6b546632e..7fe8c82db38d8 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-phy.yaml
[ ... ]
> @@ -64,7 +65,6 @@ required:
>    - clock-names
>    - vdd-supply
>    - vdda12-supply
> -  - resets

[Severity: Low]
Does removing resets from the globally required list weaken validation for
the existing SoCs?

If a device tree for older SoCs like sm8550 or sm8650 erroneously omits the
resets property, it appears it will now silently pass schema validation. 
Would it be better to add an allOf conditional block that keeps resets in
the required list for the older compatible strings that still mandate it?

>  additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916-nord-usb-phy-v2-0-2c8461bb30e6@oss.qualcomm.com?part=1