Re: [PATCH v3 2/2] arm64: dts: exynos: Add initial support for Samsung Galaxy A21s (SM-A217F)

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] dts: unintended override of mmc_0 compatible string
- [Low] dts: build failure due to undefined gpu label
--

commit 5ffd2971505c8c2076142840ef189e608c1e56c2
Author: Thomas Turner <tturner@lineageos.org>
arm64: dts: exynos: Add initial support for Samsung Galaxy A21s (SM-A217F)

This commit adds initial device tree support for the Samsung Galaxy A21s (SM-A217F) phone, based on the Exynos 850 SoC. It defaults to the 3GB RAM configuration and includes support for simple-framebuffer, buttons, MMC, USB, and watchdog.

> diff --git a/arch/arm64/boot/dts/exynos/exynos850-a217f.dts b/arch/arm64/boot/dts/exynos/exynos850-a217f.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/exynos/exynos850-a217f.dts

[ ... ]

> +&gpu {
> +	mali-supply = <&reg_dummy>;
> +
> +	status = "okay";
> +};

[Severity: Low]
Does this cause a build regression during dtc compilation? 

The gpu label is referenced here at the root level, but it appears to be 
undefined in the included exynos850.dtsi file. This would result in a 
syntax error for the missing label when running make dtbs for this board.

> +
> +&mmc_0 {
> +	compatible = "samsung,exynos7-dw-mshc";
> +	mmc-hs200-1_8v;

[Severity: Medium]
Is this generic compatible string intended to override the SoC-specific one?

The exynos850.dtsi core IP block definition properly includes the -smu suffix
for IOMMU integration. Overriding it in the board file with this older generic
string drops the IOMMU matching. This might cause DMA handling issues or
missing functionality for the MMC controller.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916205522.159393-1-tturner@lineageos.org?part=2