Re: [RFC PATCH bluetooth-next 2/3] dt-bindings: net: bluetooth: Add AIC8800D80

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: schema validation failure due to scalar const on reg array
--

commit 5a068ab01e12921fd595c8f96d78f55f50333071
Author: Yanli Yang <yanli.yang@bedmex.com>
Subject: dt-bindings: net: bluetooth: Add AIC8800D80

This commit describes the AIC8800D80 Bluetooth SDIO firmware-loading function
and UART HCI interface. It links the UART node to its SDIO firmware provider
using the aic,firmware-sdio phandle and includes an example configuration.

> diff --git a/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml
> new file mode 100644
> index 0000000000000..6fabb226cf15c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/aic,aic8800d80-bt.yaml
[ ... ]
> +allOf:
> +  - $ref: bluetooth-controller.yaml#
> +  - if:
> +      properties:
> +        compatible:
> +          const: aic,aic8800d80-bt-sdio
> +    then:
> +      properties:
> +        reg:
> +          const: 1

[Severity: Low]
Does this scalar constraint cause a schema validation failure?

In the allOf.if.then.properties.reg block for the SDIO variant, the reg
property is constrained with a scalar integer const: 1. The reg property
in Device Tree schemas is intrinsically evaluated by dt-schema as a
matrix/array of integers (e.g., reg = <1> becomes [[1]]).

Because of this, JSON Schema validation compares the array [[1]] against
the scalar 1, resulting in a type mismatch and validation failure when
running make dt_binding_check against the example or valid device trees.

> +        max-speed: false
> +        aic,firmware-sdio: false
> +      required:
> +        - reg
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/178954773705.2.3446471521233620446@bedmex.com?part=2