Re: [PATCH] dt-bindings: misc: add xlnx,axi-fifo-mm-s

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] dt-bindings: duplicate legacy text binding not removed
- [Low] dt-bindings: misc: xlnx,axi-fifo-mm-s node name contains underscores
--

commit 1e96a460ceedc5eaed86e4087bdc979b41dd1bd7
Author: Omer PALA <palaomer100@gmail.com>

dt-bindings: misc: add xlnx,axi-fifo-mm-s

Add Device Tree binding documentation for the Xilinx AXI FIFO Memory Mapped
Stream IP core. This commit covers compatible strings from version 4.1
through 4.3.

> diff --git a/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> new file mode 100644

[Severity: Low]
Is the original text binding at drivers/staging/axis-fifo/axis-fifo.txt
still needed?

Since this new YAML binding covers the same hardware in the core DT bindings
directory, should the old text binding in the staging directory be removed
in this patch to prevent documentation duplication?

> index 0000000000000..f53b353ccc2a1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/xlnx,axi-fifo-mm-s.yaml
> @@ -0,0 +1,228 @@

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - xlnx,axi-str-rxd-tdata-width
> +  - xlnx,axi-str-txd-tdata-width
> +  - xlnx,rx-fifo-depth
> +  - xlnx,tx-fifo-depth
> +  - xlnx,use-rx-data
> +  - xlnx,use-tx-data
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    axi_fifo_mm_s@43c00000 {

[Severity: Low]
Does this node name violate standard Device Tree naming conventions?

Using underscores typically triggers node_name_chars_strict warnings during
dt_binding_check validation. Should a generic name with hyphens, like
fifo@43c00000, be used instead?

> +        compatible = "xlnx,axi-fifo-mm-s-4.1";
> +        reg = <0x43c00000 0x10000>;
> +        interrupt-parent = <&intc>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917060948.14700-1-palaomer100@gmail.com?part=1