Re: [PATCH v3 1/3] pps: clients: gpio: propagate probe error codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] pps: log spam on deferred probe due to dev_err()
--

commit 7ffb1c8320d0b6933d1ffc7e8877c00811256618
Author: Eliav Farber <farbere@amazon.com>

pps: clients: gpio: propagate probe error codes

On the two probe error paths that map and request the interrupt, probe
overwrote the error from gpiod_to_irq() and request_threaded_irq() with a
hardcoded -EINVAL, hiding meaningful codes such as -EBUSY, -ENOMEM or
-EPROBE_DEFER from the caller. The request_threaded_irq() failure message
also logged the IRQ number but not the errno.

> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index 73ec2c7335e51..038c55c5f7d4a 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -165,7 +165,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
>  	ret = gpiod_to_irq(data->gpio_pin);
>  	if (ret < 0) {
>  		dev_err(dev, "failed to map GPIO to IRQ: %d\n", ret);
> -		return -EINVAL;
> +		return ret;

[Severity: Low]
Does propagating `ret` here risk console log spam if `-EPROBE_DEFER` is
returned? Since `dev_err()` is used unconditionally, it could cause log spam
during system boot if probe deferrals happen repeatedly. 

Would `dev_err_probe()` be more appropriate to handle deferred probes
silently?

>  	}
>  	data->irq = ret;
>  
> @@ -197,8 +197,8 @@ static int pps_gpio_probe(struct platform_device *pdev)
>  			  data->info.name, data);
>  	if (ret) {
>  		pps_unregister_source(data->pps);
> -		dev_err(dev, "failed to acquire IRQ %d\n", data->irq);
> -		return -EINVAL;
> +		dev_err(dev, "failed to acquire IRQ %d: %d\n", data->irq, ret);
> +		return ret;

[Severity: Low]
Similarly, does propagating the real error here risk logging spam on
deferred probes? Repeatedly deferring could trigger this `dev_err()`
multiple times. 

Would `dev_err_probe()` be more appropriate here as well?

>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917075611.47881-1-farbere@amazon.com?part=1