From: sashiko-bot@kernel.org
To: "Francesco Dolcini" <francesco@dolcini.it>
Cc: robh@kernel.org, imx@lists.linux.dev, Frank.Li@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: freescale: Add Toradex OSM iMX95
Date: Thu, 17 Sep 2026 10:28:36 +0000 [thread overview]
Message-ID: <20260917102836.C2BB31F00893@smtp.kernel.org> (raw)
In-Reply-To: <20260917102011.69071-3-francesco@dolcini.it>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: incorrect ALSA sound card name due to copy-paste error
--
commit 6c3bfda4bf1b15d78278dba5a3e6235b17a43b87
Author: Antoine Gouby <antoine.gouby@toradex.com>
arm64: dts: freescale: Add Toradex OSM iMX95
Add support for the Toradex OSM iMX95 SoM, based on an NXP i.MX95 SoC,
and its OSM development carrier board.
Link: https://www.toradex.com/computer-on-modules/osm-arm-family/nxp-imx95
Link: https://www.toradex.com/products/carrier-board/osm-development-board
> diff --git a/arch/arm64/boot/dts/freescale/imx95-toradex-osm-dev.dts b/arch/arm64/boot/dts/freescale/imx95-toradex-osm-dev.dts
> new file mode 100644
> index 0000000000000..b3d54be07c434
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx95-toradex-osm-dev.dts
[ ... ]
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,bitclock-master = <&codec_dai>;
> + simple-audio-card,format = "i2s";
> + simple-audio-card,frame-master = <&codec_dai>;
> + simple-audio-card,mclk-fs = <256>;
> + simple-audio-card,name = "verdin-wm8904";
[Severity: Medium]
Is this the correct ALSA sound card name for the OSM module?
The string defined here is exposed to userspace on the OSM standard board
and forms the ABI for the ALSA UCM (Use Case Manager) to load audio routing
profiles. If userspace matches against "verdin", it could load Verdin-specific
routing topologies that may be incorrect for the OSM carrier board, leading to
broken audio.
> + simple-audio-card,routing =
> + "Headphone Jack", "HPOUTL",
> + "Headphone Jack", "HPOUTR",
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917102011.69071-1-francesco@dolcini.it?part=2
next prev parent reply other threads:[~2026-09-17 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 10:20 [PATCH v2 0/2] arm64: dts: freescale: Add Toradex OSM iMX95 Francesco Dolcini
2026-09-17 10:20 ` [PATCH v2 1/2] dt-bindings: arm: fsl: " Francesco Dolcini
2026-09-20 11:04 ` Krzysztof Kozlowski
2026-09-17 10:20 ` [PATCH v2 2/2] arm64: dts: freescale: " Francesco Dolcini
2026-09-17 10:28 ` sashiko-bot [this message]
2026-09-17 10:31 ` Francesco Dolcini
2026-09-23 20:37 ` [PATCH v2 0/2] " Frank.Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917102836.C2BB31F00893@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=francesco@dolcini.it \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox