Re: [PATCH v18 4/5] media: qcom: camss: Add support for PHY API devices

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: select of non-existent symbol PHY_QCOM_MIPI_CSI2
--

commit b03573fcd1f12d4d07c40dc4f1d37bb4aa02040b
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

media: qcom: camss: Add support for PHY API devices

This patch adds support for using a PHY pointer that interacts with the
standard PHY API. It will try to use the new interface first, and fall back
to the legacy method if no PHYs are present in the device tree.

> diff --git a/drivers/media/platform/qcom/camss/Kconfig b/drivers/media/platform/qcom/camss/Kconfig
> index 4eda48cb1adf0..1edc5e5a1829e 100644
> --- a/drivers/media/platform/qcom/camss/Kconfig
> +++ b/drivers/media/platform/qcom/camss/Kconfig
> @@ -7,3 +7,4 @@ config VIDEO_QCOM_CAMSS
>  	select VIDEO_V4L2_SUBDEV_API
>  	select VIDEOBUF2_DMA_SG
>  	select V4L2_FWNODE
> +	select PHY_QCOM_MIPI_CSI2

[Severity: Low]
Is the symbol PHY_QCOM_MIPI_CSI2 defined somewhere in the kernel tree?

Selecting a non-existent config symbol has no effect. This means the
required PHY driver might not be automatically enabled as intended, or it
could cause Kconfig build warnings when configuring the kernel with
VIDEO_QCOM_CAMSS enabled.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v18-0-f85c9103177e@linaro.org?part=4