Re: [PATCH v5 2/2] hwmon: (pmbus/tda38740) Add driver for Infineon TDA38740/TDA38725

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] acpi: of_match_ptr() breaks PRP0001 ACPI matching without CONFIG_OF
--

commit 7b99b2a1da30b603fdd50ea7b04df230634e2572
Author: Colin Huang <u8813345@gmail.com>

hwmon: (pmbus/tda38740) Add driver for Infineon TDA38740/TDA38725

Add a PMBus driver for Infineon TDA38740 and TDA38725
single-voltage synchronous buck regulators.

> diff --git a/drivers/hwmon/pmbus/tda38740.c b/drivers/hwmon/pmbus/tda38740.c
> new file mode 100644
> index 0000000000000..1b981c7686453
> --- /dev/null
> +++ b/drivers/hwmon/pmbus/tda38740.c

[ ... ]

> +static const struct of_device_id __maybe_unused tda38740_of_match[] = {
                                     ^^^^^^^^^^^^^^
[Severity: Medium]
Could we drop this annotation? It appears it is only needed because of the
of_match_ptr() usage below.

> +	{ .compatible = "infineon,tda38725"},
> +	{ .compatible = "infineon,tda38740"},
> +	{}
> +};
> +MODULE_DEVICE_TABLE(of, tda38740_of_match);
> +
> +static struct i2c_driver tda38740_driver = {
> +	.driver = {
> +		.name = "tda38740",
> +		.of_match_table = of_match_ptr(tda38740_of_match),
                                  ^^^^^^^^^^^^
[Severity: Medium]
Will this break device binding on ACPI-based systems?

When CONFIG_OF is disabled, the of_match_ptr() macro evaluates to NULL. This
strips the of_match_table from the device_driver struct, which prevents the
ACPI subsystem from using the PRP0001 compatible string mechanism to match
and bind the device.

Dropping of_match_ptr() would allow ACPI platforms without OF to still match
using these compatible strings.

> +	},
> +	.probe = tda38740_probe,
> +	.id_table = tda38740_id,
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-add-tda38740-and-tda38725-v5-0-7fc19668ada4@gmail.com?part=2