Re: [PATCH 02/10] clk: renesas: r8a78000: Add clock for FCPV and VSP for SCP FW SDKv4.36

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] clk: renesas: cpg: SDKv4.36 clocks applied to SDKv4.31 firmware map
--

commit b14958e73ed5111dda065cb1076a7ab55add431c
Author: Paul Elder <paul.elder+renesas@ideasonboard.com>

clk: renesas: r8a78000: Add clock for FCPV and VSP for SCP FW SDKv4.36

This commit adds fixed clocks for FCPV and VSP components. It explicitly
targets the SCP firmware version SDKv4.36, adding the 266MHz variants of
the clocks to the static mappings.

> diff --git a/drivers/clk/renesas/r8a78000-cpg.c b/drivers/clk/renesas/r8a78000-cpg.c
> index b820d09e1a195..17792ff6ab8ae 100644
> --- a/drivers/clk/renesas/r8a78000-cpg.c
> +++ b/drivers/clk/renesas/r8a78000-cpg.c
> @@ -326,6 +326,8 @@ static const struct clk_map_in r8a78000_cpg_fw_4_31_0[] = {
>  	{ R8A78000_CPG_SGASYNCD16_PERW_BUS,	FIXED_CLK(66M) },
>  	{ R8A78000_CPG_S0D4_PERE_MAIN,		FIXED_CLK(200M) },
>  	{ R8A78000_CPG_MSOCK_PERW_BUS,		1667 },
> +	{ R8A78000_CPG_SGD4_VIO_DP_TX,		FIXED_CLK(266M)},
> +	{ R8A78000_CPG_SGD4_VIO_DP_OTHER,	FIXED_CLK(266M)},

[Severity: Medium]
Does this accidentally leak SDKv4.36 clocks to older firmware versions?

The commit message explicitly targets SDKv4.36, but r8a78000_cpg_fw_4_31_0
is shared by older firmware versions in r8a78000_cpg_fw_map:

drivers/clk/renesas/r8a78000-cpg.c:
	{ 0x010d0000, r8a78000_cpg_fw_4_31_0 },	/* SCP FW SDKv4.31.0 */
	{ 0x010e0000, r8a78000_cpg_fw_4_31_0 },	/* SCP FW SDKv4.32.0 */
	{ 0x01100000, r8a78000_cpg_fw_4_31_0 },	/* SCP FW SDKv4.36.0 */

Modifying the shared array applies the new clocks to versions 4.31.0 and 4.32.0
as well.

Should a new dedicated map be introduced for SDKv4.36.0 instead?

>  	{ -1 }
>  };
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-epaul-v7-3-rc1-x5h-vsp-fcp-v1-0-4c72d4e086dd@ideasonboard.com?part=2