From: Wentao Liang <vulab@iscas.ac.cn>
To: devicetree@vger.kernel.org
Cc: gaurav.minocha.os@gmail.com, grant.likely@linaro.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
saravanak@kernel.org, Wentao Liang <vulab@iscas.ac.cn>,
stable@vger.kernel.org
Subject: [PATCH] of: unittest: Fix dup node reference leak in attach_node_and_children()
Date: Thu, 17 Sep 2026 12:43:54 +0000 [thread overview]
Message-ID: <20260917124354.2151738-1-vulab@iscas.ac.cn> (raw)
of_find_node_by_path() returns a node with an elevated reference count.
When a matching node is found in the live tree the function updates the
node properties and returns without dropping that reference. Add the
missing of_node_put() so the reference is not leaked.
Fixes: ae9304c9d311 ("Adding selftest testdata dynamically into live tree")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
---
drivers/of/unittest.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 4078569a0f96..c4d4c10ceaa2 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -2072,6 +2072,7 @@ static void attach_node_and_children(struct device_node *np)
kfree(full_name);
if (dup) {
update_node_properties(np, dup);
+ of_node_put(dup);
return;
}
--
2.34.1
reply other threads:[~2026-09-17 12:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917124354.2151738-1-vulab@iscas.ac.cn \
--to=vulab@iscas.ac.cn \
--cc=devicetree@vger.kernel.org \
--cc=gaurav.minocha.os@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox