Re: [PATCH 2/8] dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: devfreq: missing conditional constraints for rk3568-dfi
--

commit 75c6ca72e6782643c9c65600f7fef45a8cfa9e7d
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

dt-bindings: devfreq: event: rockchip,dfi: add clocks to rk3588

This commit updates the rockchip,dfi device tree binding to document the
existence of individual channel clocks for the RK3588 DFI hardware. It
increases the maximum number of clocks from one to four and adds conditional
schema checks for the RK3399 and new RK3588 variants.

> diff --git a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> index 50d3fabe958d5..d6e06a9bea19f 100644
> --- a/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/event/rockchip,dfi.yaml
[ ... ]
> @@ -40,17 +48,50 @@ required:
>    - interrupts
>    - reg
>  
> -if:
> -  properties:
> -    compatible:
> -      contains:
> -        enum:
> -          - rockchip,rk3399-dfi
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - rockchip,rk3399-dfi

[Severity: Low]
Should the rockchip,rk3568-dfi compatible string also be included in this
enum?

The global schema constraints for clocks and clock-names were relaxed to
maxItems: 4 earlier in this patch to support the 4-channel rk3588-dfi. By
only including rk3399-dfi here, the existing rk3568-dfi compatible is omitted
from this strict 1-item limit conditional block.

Does this leave rockchip,rk3568-dfi without proper clock constraints, meaning
invalid device trees specifying too many clocks or invalid clock-names for
the rk3568 variant will now silently pass schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917-rockchip-dfi-cleanup-v1-0-4f00a97a69a6@collabora.com?part=2