Re: [PATCH v5 1/4] dt-bindings: lcdif: Add endpoint bus-width property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: fsl,lcdif: endpoint constraints bypassed for unit-addressed endpoints
--

commit fb72496bb41dc4492a1048af127118bf41d36a4a
Author: Francesco Dolcini <francesco.dolcini@toradex.com>

dt-bindings: lcdif: Add endpoint bus-width property

The DPI output of the LCD interface can be configured with a bus width
of 16, 18, or 24 bits. Introduce a bus-width property to the output
endpoint, specifying the number of parallel RGB bits connected.

> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 2dd0411ec6516..89cea0c14cf1d 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -68,9 +68,19 @@ properties:
>      maxItems: 1
>  
>    port:
> -    $ref: /schemas/graph.yaml#/properties/port
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    unevaluatedProperties: false
>      description: The LCDIF output port
>  
> +    properties:
> +      endpoint:

[Severity: Low]
Does restricting this to the literal 'endpoint' key bypass validation for
unit-addressed endpoints?

Existing in-tree device trees, such as arch/arm64/boot/dts/freescale/imx93.dtsi,
define unit-addressed endpoints under the lcdif port:

		lcdif_to_ldb: endpoint@1 {
			reg = <1>;

Because this uses the literal 'endpoint' key rather than a pattern property
like "^endpoint(@[0-9a-f]+)?$", multi-endpoint configurations will fail
to match this rule.

This causes device tree validation to silently bypass the bus-width enum
constraints and other video-interfaces.yaml rules for those configurations.

> +        $ref: /schemas/media/video-interfaces.yaml
> +        unevaluatedProperties: false
> +
> +        properties:
> +          bus-width:
> +            enum: [ 16, 18, 24 ]
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917140042.118181-1-francesco@dolcini.it?part=1