Re: [PATCH] arm: dts: xilinx: parallella: Enable QSPI and NOR flash

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dts: uboot-env partition is marked read-only preventing fw_setenv updates
--

commit be87c0d3af6ecbab826ce9e10b9f662f4e9662e5
Author: Aleksander Jan Bajkowski <olek2@wp.pl>

arm: dts: xilinx: parallella: Enable QSPI and NOR flash

This commit enables the QSPI controller on the Parallella board and adds the
corresponding SPI-NOR flash node along with its fixed partitions.

> diff --git a/arch/arm/boot/dts/xilinx/zynq-parallella.dts b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> --- a/arch/arm/boot/dts/xilinx/zynq-parallella.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-parallella.dts
[ ... ]
> +		partitions {
> +			compatible = "fixed-partitions";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			partition@0 {
> +				label = "uboot";
> +				reg = <0x0 0x4e0000>;
> +				read-only;
> +			};
> +
> +			partition@4e0000 {
> +				label = "uboot-env";
> +				reg = <0x4e0000 0x10000>;
> +				read-only;

[Severity: Medium]
Will this prevent standard userspace tools like fw_setenv from updating the
U-Boot environment?

The kernel MTD subsystem parses the read-only property and clears the
MTD_WRITEABLE flag for this partition. If a root user attempts to open or
write to the corresponding /dev/mtdX device, the operation will fail with
-EROFS or -EPERM.

While some board configurations intentionally restrict write access to the
bootloader environment as a policy choice, is it intended to structurally
prevent dynamic updates from Linux on the Parallella board?

> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917225317.319745-1-olek2@wp.pl?part=1