From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sander Speetjens <sander.speetjens@gmail.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Jonathan Bell <jonathan@raspberrypi.com>,
Stefan Wahren <wahrenst@gmx.net>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Dom Cobley <popcornmix@gmail.com>
Subject: Re: [PATCH v3 2/2] rtc: Add Raspberry Pi 5 RTC driver
Date: Fri, 18 Sep 2026 13:47:22 +0200 [thread overview]
Message-ID: <20260918-outrageous-myrtle-giraffe-80dfdc@quoll> (raw)
In-Reply-To: <20260917135841.841680-3-sander.speetjens@gmail.com>
On Thu, Sep 17, 2026 at 03:58:41PM +0200, Sander Speetjens wrote:
> + return devm_rtc_register_device(vrtc->rtc);
> +}
> +
> +static const struct of_device_id rpi_rtc_dt_match[] = {
> + { .compatible = "raspberrypi,firmware-rtc"},
Please fixup white space issues, see existing drivers (missing space
before }
> + {},
and unnecessary ,.
Just take existing latest code as starting point, otherwise you
reintroduce discouraged patterns.
More important: undocumented ABI.
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-18 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 13:58 [PATCH v3 0/2] Raspberry Pi 5 RTC driver Sander Speetjens
2026-09-17 13:58 ` [PATCH v3 1/2] dt-bindings: rtc: Add property for Raspberry Pi 5 RTC Sander Speetjens
2026-09-17 14:07 ` sashiko-bot
2026-09-18 11:44 ` Krzysztof Kozlowski
2026-09-18 13:27 ` Stefan Wahren
2026-09-18 19:33 ` Sander Speetjens
2026-09-21 18:51 ` Alexandre Belloni
2026-09-17 13:58 ` [PATCH v3 2/2] rtc: Add Raspberry Pi 5 RTC driver Sander Speetjens
2026-09-17 14:11 ` sashiko-bot
2026-09-18 11:47 ` Krzysztof Kozlowski [this message]
2026-09-21 18:59 ` Alexandre Belloni
2026-09-21 19:36 ` Sander Speetjens
2026-09-21 21:23 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260918-outrageous-myrtle-giraffe-80dfdc@quoll \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=jonathan@raspberrypi.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=popcornmix@gmail.com \
--cc=robh@kernel.org \
--cc=sander.speetjens@gmail.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox