Re: [PATCH 3/4] arm: dts: sunplus: add Tibbo LTPP3G2 board

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Sep 17, 2026 at 10:26:31AM +0200, Andrew Gaylard wrote:
> Add a DTS for the Tibbo LTPP3G2 board, which uses the Sunplus SP7021
> SoC. The initial DTS was provided by Sunplus Technology Co. and has
> been adapted for upstream with permission.
> 
> The board features eMMC, SPI, a bit-banged I2C EEPROM (Atmel 24C16),
> PWM output to a buzzer, a watchdog, RTC, and two GPIO LEDs (heartbeat
> and MMC activity).
> 
> Signed-off-by: Andrew Gaylard <ag@ffroot.co.za>
> ---
>  MAINTAINERS                                   |   6 +
>  arch/arm/boot/dts/sunplus/Makefile            |   5 +-
>  .../dts/sunplus/sunplus-sp7021-ltpp3g2.dts    | 182 ++++++++++++++++++
>  3 files changed, 190 insertions(+), 3 deletions(-)
>  create mode 100644 arch/arm/boot/dts/sunplus/sunplus-sp7021-ltpp3g2.dts
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a53620839407..f54a833484a0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3737,6 +3737,12 @@ F:	drivers/reset/reset-sunplus.c
>  F:	include/dt-bindings/clock/sunplus,sp7021-clkc.h
>  F:	include/dt-bindings/reset/sunplus,sp7021-reset.h
>  
> +ARM/TIBBO LTPP3G2 BOARD
> +M:	Andrew Gaylard <ag@ffroot.co.za>
> +L:	linux-arm-kernel@lists.infradead.org
> +S:	Maintained
> +F:	arch/arm/boot/dts/sunplus/sunplus-sp7021-ltpp3g2.dts
> +
>  ARM/Synaptics SoC support
>  M:	Jisheng Zhang <jszhang@kernel.org>
>  M:	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> diff --git a/arch/arm/boot/dts/sunplus/Makefile b/arch/arm/boot/dts/sunplus/Makefile
> index 868f2ea0c127..25ba2e530c35 100644
> --- a/arch/arm/boot/dts/sunplus/Makefile
> +++ b/arch/arm/boot/dts/sunplus/Makefile
> @@ -1,5 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
>  dtb-$(CONFIG_SOC_SP7021) += \
> -	sunplus-sp7021-demo-v3.dtb
> -dtb-$(CONFIG_SOC_SP7021) += \
> -	sunplus-sp7021-demo-v3.dtb
> +	sunplus-sp7021-demo-v3.dtb \
> +	sunplus-sp7021-ltpp3g2.dtb
> diff --git a/arch/arm/boot/dts/sunplus/sunplus-sp7021-ltpp3g2.dts b/arch/arm/boot/dts/sunplus/sunplus-sp7021-ltpp3g2.dts
> new file mode 100644
> index 000000000000..f91b0de79c3d
> --- /dev/null
> +++ b/arch/arm/boot/dts/sunplus/sunplus-sp7021-ltpp3g2.dts
> @@ -0,0 +1,182 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Device Tree Source for Tibbo LTPP board G2
> + *
> + * Copyright (C) 2021 Sunplus Technology Co.
> + */
> +
> +/dts-v1/;
> +
> +#include "sunplus-sp7021-achip.dtsi"
> +
> +/ {
> +	compatible = "tibbo,ltpp3g2", "sunplus,sp7021";
> +	model = "Tibbo LTPP3G2";
> +
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttySUP0,115200 earlycon root=/dev/mmcblk0p8 rootwait";

None of above should be here. earlycon is for debugging. Console is
below. root - why booting is fixed to mmc? Why none of other boot
methods are suitable or allowed?

> +		stdout-path = "serial0:115200n8";
> +	};

...

> +	pins_btuart: pinmux_btuart-pins {
> +		sunplus,pins = <
> +			SPPCTL_IOPAD(40, SPPCTL_PCTL_G_PMUX, MUXF_UA4_RX, 0)
> +			SPPCTL_IOPAD(41, SPPCTL_PCTL_G_PMUX, MUXF_UA4_TX, 0)
> +			SPPCTL_IOPAD(56, SPPCTL_PCTL_G_PMUX, MUXF_UA4_RTS, SPPCTL_PCTL_L_ONV)
> +			SPPCTL_IOPAD(49, SPPCTL_PCTL_G_PMUX, MUXF_UA4_CTS, 0)
> +		>;
> +	};
> +
> +	pins_bt_reset: pinmux_bt_reset-pins {

Please follow DTS coding style for naming.

Best regards,
Krzysztof