Re: [PATCH 1/3] dt-bindings: power: spacemit: Add power domain controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] coding_style: incorrect SPDX comment style in C header file
--

commit 3ce4bb2badb48920b29e15de6dfdfcdbc013d6c4
Author: Yixun Lan <dlan@kernel.org>

dt-bindings: power: spacemit: Add power domain controller

This commit adds initial power domain driver support for the SpacemiT K1/K3
SoC. The controller is part of the APMU and manages power across multiple
power domains, including isolation and power-on sequences.

[ ... ]

> diff --git a/include/dt-bindings/power/spacemit,k3-power.h b/include/dt-bindings/power/spacemit,k3-power.h
> new file mode 100644
> index 0000000000000..54b39f2f09364
> --- /dev/null
> +++ b/include/dt-bindings/power/spacemit,k3-power.h
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)

[Severity: Low]
This isn't a bug, but should this C header file use block comments (/* ... */)
for the SPDX license identifier?

According to the kernel licensing rules in Documentation/process/license-rules.rst,
C header files (.h) require block comments, while C++ style line comments (//)
are reserved for C source files (.c) and Device Tree sources.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-04-k3-pm-support-v1-0-0acd2b36b96f@kernel.org?part=1