Re: [PATCH v3 1/3] dt-bindings: input: touchscreen: document ESWIN EPH8621

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: eswin,eph8621: redundant properties via additionalProperties
--

commit 46b2080091d009fd58f47b811d02fd1ffe2a1da8
Author: Luca Weiss <luca.weiss@fairphone.com>

dt-bindings: input: touchscreen: document ESWIN EPH8621

Document the ESWIN EPH8621 touchscreen controller, which can operate in
SPI mode. Other touchscreen controllers from the EPH861X family (and
potentially also EPH8621) can also operate in I2C mode, this was not
added yet.

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/eswin,eph8621.yaml b/Documentation/devicetree/bindings/input/touchscreen/eswin,eph8621.yaml
> new file mode 100644
> index 0000000000000..ac7fa58644ba6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/eswin,eph8621.yaml
> @@ -0,0 +1,79 @@

[ ... ]

> +allOf:
> +  - $ref: touchscreen.yaml#
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:

[ ... ]

> +  vddio-supply:
> +    description: Power supply regulator on VDDIO pin
> +
> +  spi-max-frequency: true
> +  touchscreen-inverted-x: true
> +  touchscreen-inverted-y: true
> +  touchscreen-size-x: true
> +  touchscreen-size-y: true
> +  touchscreen-swapped-x-y: true

[Severity: Low]
Are these redundant property declarations necessary? Since the schema references
touchscreen.yaml and spi-peripheral-props.yaml in its allOf block, these can
typically be omitted if unevaluatedProperties is used instead.

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - avdd-supply
> +  - vddio-supply
> +  - touchscreen-size-x
> +  - touchscreen-size-y
> +
> +additionalProperties: false

[Severity: Low]
Would it be better to use unevaluatedProperties: false here?

By using additionalProperties: false, the schema explicitly prevents properties
defined in the referenced schemas from being implicitly allowed. This forces the
redundant declaration of properties like touchscreen-size-x and
spi-max-frequency above, and it inadvertently rejects other valid,
framework-supported touchscreen properties like touchscreen-fuzz-x.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-eswin-eph8621-v3-0-514eb1f622c0@fairphone.com?part=1