Re: [PATCH 17/21] media: i2c: it6625: require a DT endpoint and simplify endpoint parsing

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] dev_err() unconditionally logs -EPROBE_DEFER causing boot log spam
--

commit 60b825e6a08d82d6c62f40c034de7563ec028e05
Author: Hermes Wu <Hermes.wu@ite.com.tw>

media: i2c: it6625: require a DT endpoint and simplify endpoint parsing

This commit removes hardcoded configuration defaults that were applied when
no CSI-2 endpoint was found, requiring the configuration to come entirely
from the device tree. It deletes the early return for missing endpoints,
allowing the fwnode parser to handle the NULL fwnode and return -EPROBE_DEFER.

> diff --git a/drivers/media/i2c/it6625.c b/drivers/media/i2c/it6625.c
> index 4a54de2eb42bb..5fa8441f07369 100644
> --- a/drivers/media/i2c/it6625.c
> +++ b/drivers/media/i2c/it6625.c
[ ... ]
> @@ -2098,13 +2095,6 @@ static int it6625_parse_endpoint(struct it6625 *it6625)
>  			of_node_put(port_ep);
>  	}
>  
> -	if (!ep) {
> -		it6625->port_num = 1;
> -		dev_dbg(dev, "no CSI-2 endpoint node found, using default %u CSI lanes",
> -			it6625->csi_lanes);
> -		return 0;
> -	}
> -
>  	ret = v4l2_fwnode_endpoint_alloc_parse(of_fwnode_handle(ep), &endpoint);
>  	of_node_put(ep);
>  	if (ret) {
>  		dev_err(dev, "failed to parse endpoint: %d", ret);

[Severity: Medium]
Looking at it6625_parse_endpoint() in drivers/media/i2c/it6625.c, since the
early return for !ep was removed, a missing device tree endpoint node results
in ep evaluating to NULL. In this case, v4l2_fwnode_endpoint_alloc_parse()
intentionally returns -EPROBE_DEFER.

Since dev_err() is used here instead of dev_err_probe(), will this
unconditionally print an error message on every probe deferral retry and
cause boot log spam? Should dev_err_probe() be used here instead to
silence the -EPROBE_DEFER message?

>  		return ret;
>  	}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-upstream-it6625-follow-up-patch-v1-0-78d72d7886a5@ite.com.tw?part=17