Re: [PATCH v6 2/6] arm64: dts: qcom: Convert to new media orientation definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dts: qcom: missed orientation refactoring in sm8250-xiaomi-elish-common.dtsi
--

commit 118cb3cedc7acc66e33f7606b5faf0d2f7c8525a
Author: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

arm64: dts: qcom: Convert to new media orientation definitions

This commit updates users throughout the Qualcomm device trees to use the new
media orientation definitions. It replaces hardcoded integer values with the
new enum options.

> Update the users throughout the qualcomm device trees to use the new
> definitions.

[Severity: Low]
Does this refactoring miss the orientation property in arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi?

arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi:camera_front {
    ...
		pinctrl-0 = <&cam_mclk3_default &camera_front_active>;
		pinctrl-names = "default";

		orientation = <0>; /* Front facing */
		rotation = <270>;
    ...
}

It looks like this file still uses the hardcoded integer instead of the newly
introduced MEDIA_ORIENTATION_FRONT definition.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-kbingham-orientation-v6-0-5e8b1f01be29@ideasonboard.com?part=2