Re: [PATCH v2 04/10] dt-bindings: input: apple: Add DockChannel HID transport

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: custom property hid-country-code lacks vendor prefix
--

commit 2849d54fecdf9f3ef276d3d92e80cfd4525ca96e
Author: Michael Reeves <michael.reeves077@gmail.com>

dt-bindings: input: apple: Add DockChannel HID transport

This commit adds the device tree binding for the Apple DockChannel HID
transport used by internal keyboards and trackpads on Apple Silicon. It
describes the required RTKit ASC mailbox, DockChannel mailbox, and MTP DART,
along with optional STM and keyboard child nodes.

> diff --git a/Documentation/devicetree/bindings/input/apple,t8112-dockchannel-hid.yaml b/Documentation/devicetree/bindings/input/apple,t8112-dockchannel-hid.yaml
> new file mode 100644
> index 0000000000000..c25e072b68687
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/apple,t8112-dockchannel-hid.yaml

[ ... ]

> +  keyboard:
> +    type: object
> +    properties:
> +      hid-country-code:
> +        $ref: /schemas/types.yaml#/definitions/uint32

[Severity: Low]
Since this is a custom hardware-specific property inside the keyboard node,
shouldn't it include a vendor prefix to avoid namespace collisions?

Device tree guidelines mandate that hardware-specific or driver-specific
properties that are not part of a standard generic schema must be prefixed
with the vendor name, such as apple,hid-country-code.

> +        description:
> +          HID country code for the keyboard layout variant.
> +
> +    additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260918-apple-mtp-keyboard-final-v2-0-a5c685e50b60@gmail.com?part=4